823793 - [B2G][Browser]: Long site names and addresses in the Top Sites/Bookmark/History tabs do not have their text truncated gracefully

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Chris Kreinbring [:CKreinbring]]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20100101 Firefox/17.0
Build ID: 20121128204232

Steps to reproduce:

Unagi version: 20121217070202
Test case ID: 1711

1. From the home screen, launch the browser.
2. Tap the URL bar and enter a long URL and tap the enter key.  Skip this step if there is one already in one of the tabs.
3. Tap the URL bar and look for the site in the Top Sites or History tab.
4. Observe the appearance of the site's title and address.


Actual results:

The title and address are truncated at the edge of the screen with no warning or elipses.


Expected results:

The title and address are truncated at a point that is not in the middle of a word.

Comment 1

[Chris Kreinbring [:CKreinbring]]

Still repros in Unagi version 20130117070201.

Comment 2

[Chris Kreinbring [:CKreinbring]]

Still repros on Unagi version 20130208070301
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/71ddeff45ec2
Gaia: cff23a80c41b7de223d27c6a6f1f82f95c9c5f6b
Kernel: Dec 5

Comment 3

[Ben Francis [:benfrancis]]

Larissa, is it vitally important that web site names and addresses are truncated with an ellipses, or should we ask QA to amend this test case?

Comment 4

[Larissa Co [:lco]]

I think it's important to truncate with an ellipsis because it looks more elegant and polished, and it lets the user know that we aren't "broken".

However, if it's at all easier to truncate the last three characters rather than at the end of the word (e.g, "Mozilla -- Home of the Moz..." vs, "Mozilla -- Home of the Mozilla"), that is fine for now.

Comment 5

[Sam Joch [:samjoch]]

Attachment: Patch

Comment 6

[Sam Joch [:samjoch]]

Attachment: Before / After patch Screenshots

Comment 7

[Peter La]

Looks great, thanks Sam!

Comment 8

[Sam Joch [:samjoch]]

Landed in uxbranch: https://github.com/gordonbrander/gaia/commit/bf6133d697e41f17586c544d1adff44447d09b9e

Comment 9

[Sam Joch [:samjoch]]

Comment on attachment 720695 [details]
Patch

Landed in master: https://github.com/mozilla-b2g/gaia/commit/fdda34dfbce6ba94dc0b4c3743bad9a607595a4f


NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: The website name will be truncated in browser bookmarks or in websites lists.
Testing completed: Yes
Risk to taking this patch (and alternatives if risky): No risk just a text-overflow added.
String or UUID changes made by this patch: -

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 720695 [details]
Patch

This comes from the UX branch process where QA has already checked that it works. a=me.

Comment 11

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

verified on master

Master build : 2013-04-05-03-05-43
name="mozilla-central" revision="55f9e3e3dae7"  
name="integration/gaia-central" revision="2005e026bdae"
"gecko.git" revision="66b64f47a4eac1bd4f5ea6748b42ddf732297550"
"gaia.git" revision="15468abcba0dd2549f0c102df887a5c049b9c641"
Unagi

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit fdda34dfbce6ba94dc0b4c3743bad9a607595a4f as:
v1-train: c8c2c6fb0d699b6099d73a6c7f7dfe80aa8f702e