User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20100101 Firefox/17.0 Build ID: 20121128204232 Steps to reproduce: Unagi version: 20121217070202 Test case ID: 1711 1. From the home screen, launch the browser. 2. Tap the URL bar and enter a long URL and tap the enter key. Skip this step if there is one already in one of the tabs. 3. Tap the URL bar and look for the site in the Top Sites or History tab. 4. Observe the appearance of the site's title and address. Actual results: The title and address are truncated at the edge of the screen with no warning or elipses. Expected results: The title and address are truncated at a point that is not in the middle of a word.
Still repros in Unagi version 20130117070201.
Still repros on Unagi version 20130208070301 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/71ddeff45ec2 Gaia: cff23a80c41b7de223d27c6a6f1f82f95c9c5f6b Kernel: Dec 5
Larissa, is it vitally important that web site names and addresses are truncated with an ellipses, or should we ask QA to amend this test case?
I think it's important to truncate with an ellipsis because it looks more elegant and polished, and it lets the user know that we aren't "broken". However, if it's at all easier to truncate the last three characters rather than at the end of the word (e.g, "Mozilla -- Home of the Moz..." vs, "Mozilla -- Home of the Mozilla"), that is fine for now.
status-b2g18: --- → affected
tracking-b2g18: ? → +
Created attachment 720703 [details] Before / After patch Screenshots
Looks great, thanks Sam!
Landed in uxbranch: https://github.com/gordonbrander/gaia/commit/bf6133d697e41f17586c544d1adff44447d09b9e
Whiteboard: visual design → visual design, uxbranch, landed in uxbranch
Comment on attachment 720695 [details] Patch Landed in master: https://github.com/mozilla-b2g/gaia/commit/fdda34dfbce6ba94dc0b4c3743bad9a607595a4f NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: The website name will be truncated in browser bookmarks or in websites lists. Testing completed: Yes Risk to taking this patch (and alternatives if risky): No risk just a text-overflow added. String or UUID changes made by this patch: -
Comment on attachment 720695 [details] Patch This comes from the UX branch process where QA has already checked that it works. a=me.
Attachment #720695 - Flags: approval-gaia-v1?(21) → approval-gaia-v1+
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
verified on master Master build : 2013-04-05-03-05-43 name="mozilla-central" revision="55f9e3e3dae7" name="integration/gaia-central" revision="2005e026bdae" "gecko.git" revision="66b64f47a4eac1bd4f5ea6748b42ddf732297550" "gaia.git" revision="15468abcba0dd2549f0c102df887a5c049b9c641" Unagi
Status: RESOLVED → VERIFIED
Uplifted commit fdda34dfbce6ba94dc0b4c3743bad9a607595a4f as: v1-train: c8c2c6fb0d699b6099d73a6c7f7dfe80aa8f702e
status-b2g18: affected → fixed
You need to log in before you can comment on or make changes to this bug.