823820 - Intermittent Android "/tests/toolkit/components/url-classifier/tests/mochitest/test_classifier.html | Should not load bad javascript - got loaded malware javascript!, expected untouched," & "Should not load bad css", "failed to block evilWorker.js", &more

Status: RESOLVED WORKSFORME

(Toolkit :: Safe Browsing, defect)

Description

[Daniel Holbert [:dholbert] (blocking needinfo/review, due to AFK on parental leave 12/9 - 1/6)]

Bug 589585 has been closed (with no reports of sporadic failures) for over 2 years, so I'm filing this new bug for the 2 failures that were starred as that today.

The failures were bug 589585 comment 15 and bug 589585 comment 16 -- contents below: 
{
rnewman
https://tbpl.mozilla.org/php/getParsedLog.php?id=18147582&tree=Mozilla-Beta
Android Tegra 250 mozilla-beta opt test mochitest-8 on 2012-12-20 17:18:15
slave: tegra-212

72051 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/url-classifier/tests/mochitest/test_classifier.html | Should not load bad javascript - got loaded malware javascript!, expected untouched
72052 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/url-classifier/tests/mochitest/test_classifier.html | Should not load bad css - didn't expect hidden, but got it
72055 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/url-classifier/tests/mochitest/test_classifier_worker.html | failed to block evilWorker.js - got failure, expected success
72056 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/url-classifier/tests/mochitest/test_classifier_worker.html | failed to block importScripts('evilWorker.js') - got failure, expected success
I/GeckoDump( 1754): 72051 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/url-classifier/tests/mochitest/test_classifier.html | Should not load bad javascript - got loaded malware javascript!, expected untouched
I/GeckoDump( 1754): 72052 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/url-classifier/tests/mochitest/test_classifier.html | Should not load bad css - didn't expect hidden, but got it
I/GeckoDump( 1754): 72055 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/url-classifier/tests/mochitest/test_classifier_worker.html | failed to block evilWorker.js - got failure, expected success
I/GeckoDump( 1754): 72056 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/url-classifier/tests/mochitest/test_classifier_worker.html | failed to block importScripts('evilWorker.js') - got failure, expected success

=============

rnewman
https://tbpl.mozilla.org/php/getParsedLog.php?id=18147549&tree=Mozilla-Beta
Android Armv6 Tegra 250 mozilla-beta opt test mochitest-8 on 2012-12-20 17:14:23
slave: tegra-352

72051 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/url-classifier/tests/mochitest/test_classifier.html | Should not load bad javascript - got loaded malware javascript!, expected untouched
72052 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/url-classifier/tests/mochitest/test_classifier.html | Should not load bad css - didn't expect hidden, but got it
72055 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/url-classifier/tests/mochitest/test_classifier_worker.html | failed to block evilWorker.js - got failure, expected success
72056 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/url-classifier/tests/mochitest/test_classifier_worker.html | failed to block importScripts('evilWorker.js') - got failure, expected success
I/GeckoDump( 1721): 72051 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/url-classifier/tests/mochitest/test_classifier.html | Should not load bad javascript - got loaded malware javascript!, expected untouched
I/GeckoDump( 1721): 72052 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/url-classifier/tests/mochitest/test_classifier.html | Should not load bad css - didn't expect hidden, but got it
I/GeckoDump( 1721): 72055 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/url-classifier/tests/mochitest/test_classifier_worker.html | failed to block evilWorker.js - got failure, expected success
I/GeckoDump( 1721): 72056 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/url-classifier/tests/mochitest/test_classifier_worker.html | failed to block importScripts('evilWorker.js') - got failure, expected success

}

This is a particularly scary sort of thing to regress...

Comment 1

[Daniel Holbert [:dholbert] (blocking needinfo/review, due to AFK on parental leave 12/9 - 1/6)]

Oh, thank goodness -- looking at actual TBPL when this failed, it looks like both failures were part of a largely-orange cycle, with a push for bug Bug 820283:
 https://tbpl.mozilla.org/?tree=Mozilla-Beta&rev=f4467b37dfef
...and that cset's patch was backed out in the next cycle, and these tests passed in that cycle.

So -- looks like this was just fallout from a (backed out) busted push.  Phew.