823894 - [USSD/MMI] Home button is not properly handled while MMI screen is shown

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

STR:

0. Open the dialer app.
1. Send an USSD message.
2. The MMI screen is opened.
3. Click HOME button.
4. The MMI screen is hidden.
5. Reopen the dialer app.
6. The dialer is shown and after that the MMI screen is shown again.
7. Repeat steps 3-5

Expected:
6.

Current: 
The dialer is shown and after that the MMI screen is opened with the an infinite "Sending" spinner.

It only happens with USSD messages, not single MMI codes (like *#06#).

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Nominating as bb+ since the dialer is unusable when this issue happens.

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

Triage: BB-, tracking-b2g18+
not a common user scenario

Comment 3

[Germán Toro del Valle (:gtorodelvalle)]

The problem was due to the notification of 'voicechange' events which do not cause any message change in the USSD/MMI UI (only on the header) and consequently was impeding this UI to recover its previous state in case the user clicked on the Home button or moved to any other app.

Comment 4

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Associated PR.

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Please German, nominate first to go to triage if you think is an important bug.

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Nominating as per comment 1

Comment 7

[Germán Toro del Valle (:gtorodelvalle)]

Thanks Francisco! I was waiting to talk to Mari Ángeles but it seems it is the way to proceed. Thanks again!

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 703365 [details] [diff] [review]
Associated PR.

a=me

Not pretty risky and it fixes a important issue in the dialer.

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/pull/7668