Last Comment Bug 823977 - Events are missing from the calendar in recent lightning nightlies
: Events are missing from the calendar in recent lightning nightlies
: regression
Product: Calendar
Classification: Client Software
Component: General (show other bugs)
: Lightning 2.2
: All All
-- major (vote)
: 2.2
Assigned To: Brian O'Keefe [:bokeefe]
Depends on: 820377
  Show dependency treegraph
Reported: 2012-12-21 09:24 PST by Brian O'Keefe [:bokeefe]
Modified: 2013-01-06 03:27 PST (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

Patch v1 (1.20 KB, patch)
2012-12-21 09:28 PST, Brian O'Keefe [:bokeefe]
philipp: review+
Details | Diff | Splinter Review

Description User image Brian O'Keefe [:bokeefe] 2012-12-21 09:24:51 PST
Since the 12/19/12 nightly, at least, I'm missing events from a local calendar. The error console has lots of occurrences of a TypeError:

Timestamp: 12/21/2012 8:20:22 AM
Error: [Exception... "'TypeError: accounts.Count is not a function' when calling method: [calISchedulingSupport::isInvitation]"  nsresult: "0x8057001c (NS_ERROR_XPC_JS_THREW_JS_OBJECT)"
location: "JS frame :: resource://calendar/modules/calUtils.jsm"

I had nothing work-related to be doing, so I whipped up a patch. I'll attach it as soon as my local test run finishes.
Comment 1 User image Brian O'Keefe [:bokeefe] 2012-12-21 09:28:37 PST
Created attachment 694882 [details] [diff] [review]
Patch v1

This fixes both the error and the missing events on my end.
Comment 2 User image Stefan Sitter 2012-12-23 05:33:08 PST
There were a bunch of API changes that need to be incoporated into Lightning. Maybe there are more code places affected in Lightning. The post at has a short summarization of the changes.
Comment 3 User image Brian O'Keefe [:bokeefe] 2013-01-02 11:20:27 PST
I looked through the tree (well, for calendar, at least), and it looks like these were the only two changes needed. The two previous commits look to have covered the rest.
Comment 4 User image Philipp Kewisch [:Fallen] 2013-01-06 03:25:48 PST
Pushed to comm-central changeset f54ccbd9d422
Comment 5 User image Philipp Kewisch [:Fallen] 2013-01-06 03:27:39 PST
Comment on attachment 694882 [details] [diff] [review]
Patch v1

Looks good, thanks!

Note You need to log in before you can comment on or make changes to this bug.