823986 - [Wrapper] double tapping home button will show the wrapper around the homescreen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect, P3)

Description

[Tony Chung [:tchung]]

Attachment: screenshot

You can get the browser wrapper to wrap around the homescreen and any core apps.  This is caused after trying to double tap home button when a e.me app (or browser bookmark) is open

Screenshot.

Repro:
1) install nightly unagi build, 20121220092540
2) add a browser bookmark or e.me app to the homescreen
3) launch that bookmark or e.me app
4) double tap the system Home button.
5) Verify app exits, and the homescreen is within the wrapper

Expected;
- double tapping should kill the wrapper as well

Actusl;
- wrapper stays.  you can proceed with using the phone within the wrapper.

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

Triage: BB-.P4, tracking-b2g18+. 
should not block if this were the last bug before ship. doesn't block usage

Comment 2

[Tony Chung [:tchung]]

I'm going to renominate this bug for bb? triage.  this is easily reproducible, and all sorts of weird things happen once you're in the wrapper.  For example, overlays are getting confused which to focus on, and more frequent crashes occur within e.me apps that is affecting the entire homescreen.

josh also tells me that e.me guys are here this week, and might be able to look at it.

Comment 3

[Tony Chung [:tchung]]

(In reply to Tony Chung [:tchung] from comment #2)
> I'm going to renominate this bug for bb? triage.  this is easily
> reproducible, and all sorts of weird things happen once you're in the
> wrapper.  For example, overlays are getting confused which to focus on, and
> more frequent crashes occur within e.me apps that is affecting the entire
> homescreen.
> 
> josh also tells me that e.me guys are here this week, and might be able to
> look at it.

Ignore this comment, its probably more a benfrancis question, since its not just e.me apps, but also affects browser bookmarks on homescreen.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

This is a bug in system app window manager I believe ;) not e.me

(In reply to Tony Chung [:tchung] from comment #3)
> (In reply to Tony Chung [:tchung] from comment #2)
> > I'm going to renominate this bug for bb? triage.  this is easily
> > reproducible, and all sorts of weird things happen once you're in the
> > wrapper.  For example, overlays are getting confused which to focus on, and
> > more frequent crashes occur within e.me apps that is affecting the entire
> > homescreen.
> > 
> > josh also tells me that e.me guys are here this week, and might be able to
> > look at it.
> 
> Ignore this comment, its probably more a benfrancis question, since its not
> just e.me apps, but also affects browser bookmarks on homescreen.

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

related to fix from bug 799497?  I had a similar bug reported but it was placed as a dup of bug 799497.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Stealing the stealer!

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

When you double click on the home button the window manager code calls a new setDisplayedApp(homescreen) if a transition is currently happening which results into an instantaneous stop of the transition. That's not bad but since the wrapper buttons are hidden only at the end of the transition under a transitionend event that does not work in this case. The patch simply moves the removal out of the transitionend path which is not done for the wrapper anyway.

Comment 8

[Cristian Rodriguez (:crdlc)]

please give me the branch to test, thanks

Comment 9

[Cristian Rodriguez (:crdlc)]

Comment on attachment 699185 [details] [diff] [review]
Patch

It is perfect because I remember the problem :) thanks a lot Vivien!!!!

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/87fead6a77ae3de42ef070e25d4600ff2f7ed9cb