Closed Bug 824073 Opened 7 years ago Closed 7 years ago

In preferences dialog, compose pane, disable the "minutes" textbox, when autosave is not checked and "keywords" when "missing attachments" is not checked

Categories

(Thunderbird :: Preferences, defect, minor)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 21.0

People

(Reporter: aceman, Assigned: aceman)

Details

(Keywords: polish)

Attachments

(1 file, 1 obsolete file)

6.15 KB, patch
bwinton
: ui-review+
Details | Diff | Splinter Review
In preferences dialog, compose pane, disable the "minutes" textbox, when autosave is not checked and "keywords" when "missing attachments" is not checked. Similarly to controls on other panes.
Attached patch patch (obsolete) — Splinter Review
Attachment #694972 - Flags: ui-review?(bwinton)
Attachment #694972 - Flags: review?(mconley)
Status: NEW → ASSIGNED
Comment on attachment 694972 [details] [diff] [review]
patch

Review of attachment 694972 [details] [diff] [review]:
-----------------------------------------------------------------

Just two nits, but otherwise, I'm happy with this.

::: mail/components/preferences/compose.js
@@ +69,3 @@
>    enableElement: function(aElement, aEnable)
>    {
> +    let pref = aElement.getAttribute("preference");

Hm - I'm not really wild about how we re-use the pref variable for two different things here.

On line 73, I think I'd prefer a new variable called "isLocked" or something.

::: mail/components/preferences/compose.xul
@@ +48,3 @@
>        <preference id="msgcompose.font_size"      name="msgcompose.font_size" type="string"/>
>        <preference id="msgcompose.text_color"     name="msgcompose.text_color" type="string"/>
>        <preference id="msgcompose.background_color" name="msgcompose.background_color" type="string"/>      

While you're here, please trim this whitespace.
Attachment #694972 - Flags: review?(mconley) → review+
Attached patch patch v2Splinter Review
Attachment #694972 - Attachment is obsolete: true
Attachment #694972 - Flags: ui-review?(bwinton)
Attachment #698035 - Flags: ui-review?(bwinton)
Comment on attachment 698035 [details] [diff] [review]
patch v2

Looks good!  ui-r=me!

Thanks,
Blake.
Attachment #698035 - Flags: ui-review?(bwinton) → ui-review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/3c5f1a6215cf
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 21.0
You need to log in before you can comment on or make changes to this bug.