824087 - [B2G][Settings] Wi-Fi: WPA2 is displayed a WPA-PSK security in the Wi-Fi settings.

Status: VERIFIED DUPLICATE of bug 848674

(Firefox OS Graveyard :: Wifi, defect)

Description

[Darren]

Repro Steps:
1. Update phone to build ID: 20121217070202.
2. Go to "Settings".
3. Select "Wi-Fi".
4. Search for a source that is know to be WPA2.(Having another device Wi-Fi Hotspot with security WPA2 will also work.)

Actual Results:
The security displays the devices as being WPA-PSK.

Expected Results:
The device will display WPA2 and WPA-PSK for different wifi sources.(Depending on the security settings)

Notes:

Repro Rate:
100%

Comment 1

[Vincent Chang[:vchang][changyihsin]]

wpa and wpa2 are two different security types. Some Wifi routers allow user to select multiple authentication types including wpa-personal/wpa2-personal/wpa-wpa2-personal/wpa-enterprise/wpa2-enterprise/wpa-wpa2-enterprise. We have to distinguish them because we use authentication type and ssid as key to distinguish from different APs. We should be able to distinguish APs which have the same ssid but different authentication type.

Comment 2

[Johnny Stenback (:jst)]

Not blocking this, but if there's a trivial fix we should evaluate whether this should be uplifted.

Comment 3

[Vincent Chang[:vchang][changyihsin]]

Attachment: Patch v1.0

The wifi authentication types should be separated into wpa-psk/wpa2-psk/wpa-eap/wpa2-eap/wpa-psk+wpa2-psk/wpa-eap+wpa2-eap. This patch tried to address this issue.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 698193 [details] [diff] [review]
Patch v1.0

Review of attachment 698193 [details] [diff] [review]:
-----------------------------------------------------------------

This looks pretty good to me. A few comments below.

::: dom/wifi/WifiWorker.js
@@ +1382,5 @@
>  
> +// Network object structure
> +// {
> +//   .ssid           : SSID of AP
> +//   .capabilities[] : "WPA-PSK" for WPA-PSK

This comment needs to be updated now, right?

@@ +1394,5 @@
> +//   .auth_alg       : Encryption algorithm(WEP mode only)
> +//                     "OPEN_SHARED" for WEP
> +//   other keys
> +// }
> +var networkElement = (function () {

Maybe NetworkElement.

@@ +1677,5 @@
> +        capabilities = ["WPA-PSK", "WPA2-PSK"];
> +      } else {
> +        if (net.proto == "WPA") {
> +          capabilities = ["WPA-PSK"];
> +        } else if(net.proto == "RSN") {

Nit: here and below: space after if.

@@ +1740,5 @@
> +      net.proto = "WPA";
> +    } else if (type === "WPA2-PSK" || type === "WPA2-EAP") {
> +      configured.key_mgmt = net.key_mgmt = type.replace("2", "");
> +      net.proto = "RSN";
> +    } else if (type === "WPA-PSK+WPA2-PSK" || type === "WPA2-PSK+WPA-PSK") {

Can we sort the capabilities array or something so we don't have to worry about order here?

Comment 5

[Vincent Chang[:vchang][changyihsin]]

Attachment: Patch v1.1

1. Addressed the feedback comments. 
2. Fixed forget network doesn't work issue.

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 699595 [details] [diff] [review]
Patch v1.1

I think we talked about this and decided that it needed more work.

Comment 7

[Vincent Chang[:vchang][changyihsin]]

This is duplicate of Bug 848674 which is marked as tef+. Let's close this bug and discuss there.

Comment 8

[Darren]

Verified as dupe of 848674.