824133 - Show the appropriate error message when user loses connectivity on his/her unagi phone

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[krupa raj[:krupa]]

steps to reproduce:
1.Launch your marketplace-dev app
2.Navigate to Settings page
3. Disable wifi
4. Relaunch marketplace app and click submit changes on the settings page

expected behavior:
We show "You need to be online to access the marketplace app" screen.

observed behavior:
We show a lightbox with "A server error has occurred". Stop blaming the poor server for things it didn't do!

Comment 1

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/7251c9e

Comment 2

[krupa raj[:krupa]]

We just show the throbber now. We don't the offline error message anymore.

Comment 3

[krupa raj[:krupa]]

(In reply to krupa raj 82[:krupa] from comment #2)
> We just show the throbber now. We don't the offline error message anymore.

We don't *show* the offline error message anymore.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

(In reply to krupa raj 82[:krupa] from comment #3)
> (In reply to krupa raj 82[:krupa] from comment #2)
> > We just show the throbber now. We don't the offline error message anymore.
> 
> We don't *show* the offline error message anymore.

Well we do/should show the offline error message if you navigate to another page and don't have wifi anymore. The throbber issue was a JS error that Potch was able to reproduce (can't find the bug number).

The issue that I haven't fixed is this:

1) You're online. You're browsing the Marketplace.
2) You leave the Marketplace. You lose connectivity.
3) You return to the Marketplace. We don't immediately check your online status when the app is relaunched.

That case I will fix. But if the case mentioned above is reproducible, I'm highly concerned.

Comment 5

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/cc371c9

I can open this in a dialog if that is preferred. Holler at me.