Closed Bug 824163 Opened 8 years ago Closed 8 years ago

Can't use the jstestbrowser Makefile target with TESTS_PATH

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
The current rule:

jstestbrowser: TESTS_PATH?=test-package-stage/jsreftest/tests/
jstestbrowser:
	$(MAKE) -C $(DEPTH)/config
	$(MAKE) -C $(DEPTH)/js/src/config
	$(MAKE) stage-jstests
	$(call RUN_REFTEST,$(DIST)/$(TESTS_PATH)/jstests.list --extra-profile-file=$(DIST)/$(TESTS_PATH)/user.js)
	$(CHECK_TEST_ERROR)

The --extra-profile-file argument is used to dump a user.js in the profile, with settings such that the browser will allow the JS tests to do privileged stuff like set preferences and the like.  That file lives at js/src/tests/user.js.  It doesn't live at the location of the test subset being run.  So this shouldn't be using $(TESTS_PATH) in that file path.
Attachment #695052 - Flags: review?(ted)
Attachment #695052 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/f9f27086d5de
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.