824163 - Can't use the jstestbrowser Makefile target with TESTS_PATH

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

Attachment: Patch

The current rule:

jstestbrowser: TESTS_PATH?=test-package-stage/jsreftest/tests/
jstestbrowser:
	$(MAKE) -C $(DEPTH)/config
	$(MAKE) -C $(DEPTH)/js/src/config
	$(MAKE) stage-jstests
	$(call RUN_REFTEST,$(DIST)/$(TESTS_PATH)/jstests.list --extra-profile-file=$(DIST)/$(TESTS_PATH)/user.js)
	$(CHECK_TEST_ERROR)

The --extra-profile-file argument is used to dump a user.js in the profile, with settings such that the browser will allow the JS tests to do privileged stuff like set preferences and the like.  That file lives at js/src/tests/user.js.  It doesn't live at the location of the test subset being run.  So this shouldn't be using $(TESTS_PATH) in that file path.

Comment 1

[Jeff Walden [:Waldo]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f9f27086d5de

Comment 2

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/f9f27086d5de