Closed Bug 824164 Opened 7 years ago Closed 7 years ago

change in layout of chat menu

Categories

(Firefox Graveyard :: SocialAPI, defect)

19 Branch
x86
macOS
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 23

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

References

Details

(Keywords: uiwanted)

Attachments

(3 files, 8 obsolete files)

For better visibility we should change the location of the nub to be immediately to the left of the chat windows, rather than being left justified.  If that is not possible, moving it next to sidebar would at least connect it more with the provider.

requesting ux/design input
Attached patch chat nub location.patch (obsolete) — Splinter Review
quick patch to show change of location for chat nub
Attached image chatnub.png (obsolete) —
image showing new location of nub
Whiteboard: [needs-ux]
Keywords: uiwanted
Whiteboard: [needs-ux]
Attached patch chat nub location.patch (obsolete) — Splinter Review
Attachment #702087 - Attachment is obsolete: true
Attached image chatnub.png
Attachment #702089 - Attachment is obsolete: true
Attachment #738717 - Flags: ui-review?(jboriss)
Putting the overflow nub on the left is a good way to handle this, but let’s style the nub’s background identically to the top of chat windows themselves.  After all, both are the “collapasible” handles, editable via cursor click, to a larger portion of a network's content.

I can r+ this bug just the styling - items of how the nub behaves and displays should be looked at as well.  Not able to reproduce the nub in the current build - should it be in there?
Attached image default nub color.png (obsolete) —
Attached image open nub color.png (obsolete) —
fixes nub color per irc with boriss about the suggested change in the mockup.  The primary issue was the transparency on the nub image by default.  The goal is to match the button appearance with the minimized chat window appearance.
Assignee: jboriss → mixedpuppy
Attachment #738716 - Attachment is obsolete: true
Attachment #740468 - Attachment is obsolete: true
Attachment #740471 - Attachment is obsolete: true
Attachment #740499 - Flags: review?(mhammond)
(trying again, getting weird Bugzilla errors today)

After talking through this on IRC and giving it some though, I'm attaching a new mockup with some tweaks to the previous one.  

The mockup shows the nub in "inactive" color state by default, while "active" state only when the user is actively engaging with the menu.  This seems like the most consistent way to handle the coloring, and also means that a collapsed chat tab of the same height uses the same color scheme as the button rather than appearing "less active" than it.

I've also included two views of the menu that comes from the nub - one as a "goal" state consistent with Australis styling, and one as a default placeholder if that's too difficult to achieve in time for next code freeze.
Attachment #740512 - Attachment is obsolete: true
Comment on attachment 740499 [details] [diff] [review]
chat nub location.patch

I get the impression from Boriss's later comments that this patch will still need further tweaks, so clearing review request - let me know if I misunderstood.
Attachment #740499 - Flags: review?(mhammond)
Blocks: 866172
(In reply to Mark Hammond (:markh) from comment #12)
> Comment on attachment 740499 [details] [diff] [review]
> chat nub location.patch
> 
> I get the impression from Boriss's later comments that this patch will still
> need further tweaks, so clearing review request - let me know if I
> misunderstood.

We're not handling the australis styling in this bug, the followup for that is bug 866172.
Comment on attachment 740499 [details] [diff] [review]
chat nub location.patch

Either Mark or Felipe (since it's now Marks weekend)
Attachment #740499 - Flags: review?(mhammond)
Attachment #740499 - Flags: review?(felipc)
Comment on attachment 740499 [details] [diff] [review]
chat nub location.patch

Review of attachment 740499 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM - clearing Felip's request as you asked for either
Attachment #740499 - Flags: review?(mhammond)
Attachment #740499 - Flags: review?(felipc)
Attachment #740499 - Flags: review+
don't try before the first coffee.  here's a new one

https://tbpl.mozilla.org/?tree=Try&rev=a635f2d95737
Depends on: 869278
https://hg.mozilla.org/mozilla-central/rev/f0b7c3e3b622
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Attachment #738717 - Flags: ui-review?(jboriss)
Verified fixed for Firefox 23.
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.