824164 - change in layout of chat menu

Status: VERIFIED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Shane Caraveo (:mixedpuppy)]

For better visibility we should change the location of the nub to be immediately to the left of the chat windows, rather than being left justified.  If that is not possible, moving it next to sidebar would at least connect it more with the provider.

requesting ux/design input

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: chat nub location.patch

quick patch to show change of location for chat nub

Comment 2

[Shane Caraveo (:mixedpuppy)]

Attachment: chatnub.png

image showing new location of nub

Comment 3

[Shane Caraveo (:mixedpuppy)]

Attachment: chat nub location.patch

Comment 4

[Shane Caraveo (:mixedpuppy)]

Attachment: chatnub.png

Comment 5

[Jennifer Morrow [:Boriss] (UX)]

Attachment: Mockup: Current nub styling and goal state nub styling to match chat titlebar

Putting the overflow nub on the left is a good way to handle this, but let’s style the nub’s background identically to the top of chat windows themselves.  After all, both are the “collapasible” handles, editable via cursor click, to a larger portion of a network's content.

I can r+ this bug just the styling - items of how the nub behaves and displays should be looked at as well.  Not able to reproduce the nub in the current build - should it be in there?

Comment 6

[Shane Caraveo (:mixedpuppy)]

Attachment: default nub color.png

Comment 7

[Shane Caraveo (:mixedpuppy)]

Attachment: open nub color.png

Comment 8

[Shane Caraveo (:mixedpuppy)]

Attachment: chat nub location.patch

fixes nub color per irc with boriss about the suggested change in the mockup.  The primary issue was the transparency on the nub image by default.  The goal is to match the button appearance with the minimized chat window appearance.

Comment 9

[Jennifer Morrow [:Boriss] (UX)]

Attachment: Mockup: Current nub styling and goal state nub styling to match chat titlebar

Comment 10

[Jennifer Morrow [:Boriss] (UX)]

Attachment: Mockup: Current nub styling and goal state nub styling to match chat titlebar

Comment 11

[Jennifer Morrow [:Boriss] (UX)]

Attachment: Mockup: Current nub styling and goal state nub styling to match chat titlebar

(trying again, getting weird Bugzilla errors today)

After talking through this on IRC and giving it some though, I'm attaching a new mockup with some tweaks to the previous one.  

The mockup shows the nub in "inactive" color state by default, while "active" state only when the user is actively engaging with the menu.  This seems like the most consistent way to handle the coloring, and also means that a collapsed chat tab of the same height uses the same color scheme as the button rather than appearing "less active" than it.

I've also included two views of the menu that comes from the nub - one as a "goal" state consistent with Australis styling, and one as a default placeholder if that's too difficult to achieve in time for next code freeze.

Comment 12

[Mark Hammond [:markh]]

Comment on attachment 740499 [details] [diff] [review]
chat nub location.patch

I get the impression from Boriss's later comments that this patch will still need further tweaks, so clearing review request - let me know if I misunderstood.

Comment 13

[Shane Caraveo (:mixedpuppy)]

(In reply to Mark Hammond (:markh) from comment #12)
> Comment on attachment 740499 [details] [diff] [review]
> chat nub location.patch
> 
> I get the impression from Boriss's later comments that this patch will still
> need further tweaks, so clearing review request - let me know if I
> misunderstood.

We're not handling the australis styling in this bug, the followup for that is bug 866172.

Comment 14

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 740499 [details] [diff] [review]
chat nub location.patch

Either Mark or Felipe (since it's now Marks weekend)

Comment 15

[Mark Hammond [:markh]]

Comment on attachment 740499 [details] [diff] [review]
chat nub location.patch

Review of attachment 740499 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM - clearing Felip's request as you asked for either

Comment 16

[Shane Caraveo (:mixedpuppy)]

https://tbpl.mozilla.org/?tree=Try&rev=106393db34d5

Comment 17

[Shane Caraveo (:mixedpuppy)]

don't try before the first coffee.  here's a new one

https://tbpl.mozilla.org/?tree=Try&rev=a635f2d95737

Comment 18

[Shane Caraveo (:mixedpuppy)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f0b7c3e3b622

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f0b7c3e3b622

Comment 20

[Anthony Hughes (:ashughes) [QA]]

Verified fixed for Firefox 23.