824187 - [gallery] open activity does not support gif files, so e-mail can't display gif files

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

## Environment :
Unagi phone, build 2012-12-21

## Repro :
1. send yourself a gif file
2. launch email on the device
3. set up the email address that you sent the gif file
4. sync the account
5. select the email and try to download the file
6. select view

## Expected :
1. you can view the gif

## Actual :
1. nothing happens

## Note :
logcat:
12-21 18:10:09.152: I/GeckoDump(600): [32mLOG: trying to open pictures,bug.gif type: image/gif[0m
12-21 18:10:09.192: I/GeckoDump(600): [33mWAR: Problem with "open" activity NO_PROVIDER[0m

Comment 1

[David Flanagan [:djf]]

Gallery supports jpeg for camera photos and png for screenshots. I didn't think about transferred images when limiting the list to those two types.  Adding GIF would probably be a one-line change to manifest.webapp. So if this is a valid use (and I don't see why it shouldn't be) please make this blocking so I can fix it.

Assigning this to myself and nominating.

Comment 2

[David Scravaglieri [:scravag]]

If this case is reported massevely by dogfooders it will be blocked.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

(In reply to David Scravaglieri [:scravag] from comment #2)
> If this case is reported massevely by dogfooders it will be blocked.

Would approval be granted for a patch?  I can guarantee I'll spend more time duping bugs to this one than it would take djf or myself to fix and someone to review it.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

I landed a fix for the display aspect of this in:
https://github.com/mozilla-b2g/gaia/pull/7525
from bug 828578.

The gif worked fine, although gallery itself did not scan and find the gif, suggesting that gifs may end up constituting a disk space leak...

I am marking this fixed because the leak is independent of the display issue.  We should probably file a spin-off for that in case I was not hallucinating.

Comment 5

[David Flanagan [:djf]]

This was on my list of things to fix this week. I'll cross it off!

I kind want the gallery app to be for photos, and not become a generic image viewer, so I'd rather not make the gallery display any image the user saves.  But I'll accept product or UX guidance on this.  It is trivial to make the gallery display other image types.  I just don't think it is a good idea.

Maybe when the browser apps implements a save as or download feature it could have a download manager component. Or maybe we just need a download manager app that handles email attachments, bluetooth stuff, files saved by the browser, etc. Such an app could use open activities to deal with downloaded files and could allow them to be deleted, whithout

Or, if the gallery UX is ever altered to allow multiple albums, then we could have one album for photos and one for all the other images we know about.

Comment 6

[Andrew Sutherland [:asuth] (he/him)]

The e-mail app could also just delete the downloaded things when it discards the message from its cache.  Right now we don't, and treat it like downloading something in Firefox.