Last Comment Bug 824218 - Remove unimplemented SVG features
: Remove unimplemented SVG features
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: SVG (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla21
Assigned To: David Zbarsky (:dzbarsky)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-21 21:58 PST by David Zbarsky (:dzbarsky)
Modified: 2013-02-23 23:32 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (29.84 KB, patch)
2013-01-06 21:12 PST, David Zbarsky (:dzbarsky)
longsonr: review+
Details | Diff | Review

Description David Zbarsky (:dzbarsky) 2012-12-21 21:58:41 PST
It doesn't do anything useful.
Comment 1 David Zbarsky (:dzbarsky) 2013-01-06 21:06:31 PST
Having the implementations isn't useful and breaks feature testing.
Comment 2 David Zbarsky (:dzbarsky) 2013-01-06 21:12:57 PST
Created attachment 698529 [details] [diff] [review]
Patch
Comment 3 Robert Longson 2013-01-07 07:33:54 PST
Comment on attachment 698529 [details] [diff] [review]
Patch

>-/* nsIDOMCSSValue getPresentationAttribute (in DOMString name); */
>-NS_IMETHODIMP
>-nsSVGElement::GetPresentationAttribute(const nsAString& aName,
>-                                       nsIDOMCSSValue** aReturn)
>-{
>-  // Let's not implement this just yet. The CSSValue interface has been
>-  // deprecated by the CSS WG.
>-  // http://lists.w3.org/Archives/Public/www-style/2003Oct/0347.html

Please put the part of the comment starting from The CSSValue... 
in the webidl file so we don't lose it.

r=me with that.
Comment 4 David Zbarsky (:dzbarsky) 2013-01-09 15:05:09 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/9297bf41ab4d
Comment 5 Ed Morley [:emorley] 2013-01-10 01:05:20 PST
https://hg.mozilla.org/mozilla-central/rev/9297bf41ab4d
Comment 6 Kohei Yoshino [:kohei] 2013-02-23 23:32:39 PST
I've added this bug to the compatibility doc. Please correct the info if I'm wrong.
https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_21

Note You need to log in before you can comment on or make changes to this bug.