Closed Bug 824338 Opened 7 years ago Closed 7 years ago

A typo in warning message: nsRDFXMLDataSource.cpp

Categories

(Core Graveyard :: RDF, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
mozilla23

People

(Reporter: ishikawa, Assigned: ishikawa)

Details

Attachments

(1 file)

There is a typo of the world "dirty" as "diry"
in comm-central's
mozilla/rdf/base/src/nsRDFXMLDataSource.cpp 

Attached is a patch to fix this typo.
Comment on attachment 695296 [details] [diff] [review]
Fixing "diry" to "dirty"

I am afraid that I did not upload this as "patch" but
I wonder if someone could review this. This should be a no brainer.
Attachment #695296 - Flags: review?(continuation)
Comment on attachment 695296 [details] [diff] [review]
Fixing "diry" to "dirty"

Looks fine to me, but I think a Thunderbird peer should technically review this. :)
Attachment #695296 - Attachment is patch: true
Attachment #695296 - Flags: review?(continuation) → review?(mbanner)
Oh, and to set something as a patch after you uploaded it, click on "Details" for the attachment, then "edit details", then there will be a box you can check to make it a patch. Certainly not very easy to find!
(In reply to Andrew McCreight [:mccr8] from comment #3)
> Oh, and to set something as a patch after you uploaded it, click on
> "Details" for the attachment, then "edit details", then there will be a box
> you can check to make it a patch. Certainly not very easy to find!

Thanks a lot! (Now I know how to do it...)
Attachment #695296 - Flags: review?(mbanner) → review?(neil)
Comment on attachment 695296 [details] [diff] [review]
Fixing "diry" to "dirty"

Actually this isn't my module either but it's only a debug spelling fix so I can't see any problem with taking this patch.
Attachment #695296 - Flags: review?(neil) → review+
Assignee: nobody → ishikawa
Was there a reason this didn't land? The patch still applies on m-c...
(In reply to Cykesiopka from comment #6)
> Was there a reason this didn't land? The patch still applies on m-c...

It probably just got missed, sometimes it happens.

https://hg.mozilla.org/integration/mozilla-inbound/rev/16ebb913027b
Severity: minor → trivial
Target Milestone: --- → mozilla23
https://hg.mozilla.org/mozilla-central/rev/16ebb913027b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.