Closed Bug 824423 Opened 8 years ago Closed 8 years ago

Unhandled exception NS_ERROR_NOT_AVAILABLE on write failure to WebDAV calendar

Categories

(Calendar :: Provider: ICS/WebDAV, defect)

Product:
Calendar
Component:
Provider: ICS/WebDAV
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mmecca, Assigned: mmecca)

Details

Attachments

(1 file, 1 obsolete file)

Fix v2
1.91 KB, patch
Fallen
: review+
Details | Diff | Splinter Review 
If an error occurs while writing to a WebDAV calendar, in some cases nsIHttpChannel.requestSucceeded throws the following:

Error: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIHttpChannel.requestSucceeded]
Source file: .../components/calICSCalendar.js
Line: 423

This exception is unhandled and prevents graceful failure including the display of the Modification Failed error and disabling of the calendar.
Attached patch Fix v1 (obsolete) — — Splinter Review 
Handle possible exceptions when accessing requestSucceeded
Attachment #695399 - Flags: review?(philipp)
Comment on attachment 695399 [details] [diff] [review]
Fix v1

r=philipp
Attachment #695399 - Flags: review?(philipp) → review+
Matthew, was the patch already checked-in? If not, is it still valid and required?
Attached patch Fix v2 — — Splinter Review 
The log message is misleading for local ics files, since the requestSucceeded status is only relevant for an http channel.
Attachment #695399 - Attachment is obsolete: true
Attachment #774460 - Flags: review?(philipp)
Comment on attachment 774460 [details] [diff] [review]
Fix v2

r=philipp
Attachment #774460 - Flags: review?(philipp) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/839e3d7acdb1
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.7
You need to log in before you can comment on or make changes to this bug.