Closed
Bug 824443
Opened 11 years ago
Closed 11 years ago
Put the geolocation prompt's "Learn More" link in <popupnotificationcontent> rather than extending the popup notification's binding
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 20
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
6.52 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #695423 -
Flags: review?(gavin.sharp)
Updated•11 years ago
|
Attachment #695423 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 1•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/36d18c504450
Comment 2•11 years ago
|
||
Backed out for mochitest b-c failures. https://tbpl.mozilla.org/php/getParsedLog.php?id=18246908&tree=Mozilla-Inbound TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_popupNotification.js | 3 secondary actions - Got 2, expected 1 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_popupNotification.js | label for secondary action 0 matches - Got , expected Secondary Action TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_popupNotification.js | accessKey for secondary action 0 matches - Got , expected S
Comment 3•11 years ago
|
||
...and a cset link for good measure. https://hg.mozilla.org/integration/mozilla-inbound/rev/a61dd24bb0f2
Assignee | ||
Comment 4•11 years ago
|
||
710 let actualSecondaryActions = notification.childNodes; stupid test :(
Assignee | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a7f3c82ab9b
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9a7f3c82ab9b
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in
before you can comment on or make changes to this bug.
Description
•