Closed Bug 824443 Opened 7 years ago Closed 7 years ago

Put the geolocation prompt's "Learn More" link in <popupnotificationcontent> rather than extending the popup notification's binding

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 20

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
No description provided.
Attachment #695423 - Flags: review?(gavin.sharp)
Blocks: 615483
Depends on: 823443
Attachment #695423 - Flags: review?(gavin.sharp) → review+
Backed out for mochitest b-c failures.


https://tbpl.mozilla.org/php/getParsedLog.php?id=18246908&tree=Mozilla-Inbound

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_popupNotification.js | 3 secondary actions - Got 2, expected 1
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_popupNotification.js | label for secondary action 0 matches - Got , expected Secondary Action
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_popupNotification.js | accessKey for secondary action 0 matches - Got , expected S
710   let actualSecondaryActions = notification.childNodes;

stupid test :(
https://hg.mozilla.org/mozilla-central/rev/9a7f3c82ab9b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.