Closed Bug 824469 Opened 11 years ago Closed 11 years ago

"+" button should open new private tab when selected "private" column

Categories

(Firefox for Android Graveyard :: General, defect)

20 Branch
ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 20

People

(Reporter: yukikeiichi, Assigned: sriram)

References

Details

Attachments

(1 file, 1 obsolete file)

Build: Firefox for Android 20.0a1(2012-12-24)
Device: Samsung Galaxy Nexus 
OS: Android 4.2.1

Steps to reproduce:
1. Open tabs-tray
2. Select "private" column
3. Tap "+" button

Actual result:
- Open new (normal) tab.

Expected result:
- Open private tab.
Blocks: 817706
Blocks: 817675
No longer blocks: 817706
Flags: needinfo?(ibarlow)
Status: UNCONFIRMED → NEW
Ever confirmed: true
That's correct, when private tabs are open, the + should open a private tab.
Flags: needinfo?(ibarlow)
Do we have the same "+" button for both sections? Or the mask in case of private-tabs?
Attached patch Patch (obsolete) — Splinter Review
This uses the same "+" button to open normal/private tab depending on the section.
Attachment #697121 - Flags: review?(mark.finkle)
Attachment #697121 - Flags: review?(mark.finkle) → review+
Attached patch PatchSplinter Review
Oops.
This patch takes care of the remote tabs too. (4 lines extra over the previous patch).
Attachment #697121 - Attachment is obsolete: true
Attachment #697125 - Flags: review?(mark.finkle)
Attachment #697125 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/0a04bcb4ba27
Assignee: nobody → sriram
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Depends on: 826819
Verified fixed on:
-build: Firefox for Android 21.0a1 (2013-02-17)
-device: Samsung Galaxy Nexus
-OS: Android 4.2.1
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: