Closed
Bug 824469
Opened 11 years ago
Closed 11 years ago
"+" button should open new private tab when selected "private" column
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 20
People
(Reporter: yukikeiichi, Assigned: sriram)
References
Details
Attachments
(1 file, 1 obsolete file)
5.07 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Build: Firefox for Android 20.0a1(2012-12-24) Device: Samsung Galaxy Nexus OS: Android 4.2.1 Steps to reproduce: 1. Open tabs-tray 2. Select "private" column 3. Tap "+" button Actual result: - Open new (normal) tab. Expected result: - Open private tab.
Updated•11 years ago
|
Updated•11 years ago
|
Flags: needinfo?(ibarlow)
Updated•11 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 1•11 years ago
|
||
That's correct, when private tabs are open, the + should open a private tab.
Flags: needinfo?(ibarlow)
Assignee | ||
Comment 2•11 years ago
|
||
Do we have the same "+" button for both sections? Or the mask in case of private-tabs?
Assignee | ||
Comment 3•11 years ago
|
||
This uses the same "+" button to open normal/private tab depending on the section.
Attachment #697121 -
Flags: review?(mark.finkle)
Updated•11 years ago
|
Attachment #697121 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Oops. This patch takes care of the remote tabs too. (4 lines extra over the previous patch).
Attachment #697121 -
Attachment is obsolete: true
Attachment #697125 -
Flags: review?(mark.finkle)
Updated•11 years ago
|
Attachment #697125 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a04bcb4ba27
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0a04bcb4ba27
Assignee: nobody → sriram
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Comment 7•11 years ago
|
||
Verified fixed on: -build: Firefox for Android 21.0a1 (2013-02-17) -device: Samsung Galaxy Nexus -OS: Android 4.2.1
Status: RESOLVED → VERIFIED
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•