Closed Bug 824558 Opened 7 years ago Closed 7 years ago

[GPS] Quickly enable/disable geolocation might break gps provider

Categories

(Firefox OS Graveyard :: General, defect, critical)

All
Gonk (Firefox OS)
defect
Not set
critical

Tracking

(blocking-basecamp:-, firefox19 fixed, firefox20 fixed, b2g18 fixed)

RESOLVED FIXED
blocking-basecamp -
Tracking Status
firefox19 --- fixed
firefox20 --- fixed
b2g18 --- fixed

People

(Reporter: kanru, Assigned: kanru)

Details

(Keywords: crash)

Attachments

(1 file)

Currently the Startup and Shutdown of GPS provider is implemented in an async manner. However if we call Startup immediately after Shutdown we will put the Init routine to the soon to be detached thread, then we will crash in a later shutdown.

https://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/GonkGPSGeolocationProvider.cpp#575
Assignee: nobody → kchen
blocking-basecamp: --- → ?
Keywords: crash
Severity: normal → critical
Do not destroy the mInitThread because we need it to sync GPS startup and shutdown. Cost us one thread when unused, should be OK because only the chrome process will create the provider.
Attachment #695586 - Flags: review?(doug.turner)
Attachment #695586 - Flags: review?(doug.turner) → review+
https://hg.mozilla.org/mozilla-central/rev/5ec5718e4fa8
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
blocking-basecamp: ? → -
Comment on attachment 695586 [details] [diff] [review]
Do not destroy mInitThread

[Triage Comment]

safe for uplift.
Attachment #695586 - Flags: approval-mozilla-b2g18+
Attachment #695586 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.