824573 - [Settings][Cellular&Data] When you open data connection, the warning design is different than UX design

Status: RESOLVED DUPLICATE of bug 836609

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Walter Chen[:ypwalter][:wachen]]

This bug is mainly for v1.1(shira)
MozTrap Test Case: https://moztrap.mozilla.org/manage/case/5924/

*Phone: Unagi
2012-12-23 23:43:28
https://pvtbuilds.mozilla.org/pub/mozilla.org/b2g/nightly/date-unagi/2012/12/2012-12-21-23-43-28/

*How to reproduce:
  1. Go to "Settings" app
  2. "Cellular & Data"
  3. Turn on "data connection"

*Expected Result: 
    MTR-23264
    https://www.dropbox.com/s/jbyjevqh3zbusrj/Roaming%20UI_Dec%2013.pdf

*Actual Result:
    Not as the roaming ui designed

Comment 1

[Walter Chen[:ypwalter][:wachen]]

The most up-to-date result by 2012-12-27 date build:

It still doesn't have the  MTR-23264 second screen shown.
Functionality not completed

Can't test on a roaming card as for now.
local 3G doesn't have such warning, but it should have it
(suspect foreign roaming 3G card doesn't have the warning too)

Comment 2

[skrishnan]

Walter the pdf you are referring to is a wireframe and not a mock (if the screen looks acceptable and native it should be fine), also it shows that screen only once after that the second screen is never shown , we just show a inline message after the first attempt. 

(In reply to Walter Chen from comment #1)
> The most up-to-date result by 2012-12-27 date build:
> 
> It still doesn't have the  MTR-23264 second screen shown.
> Functionality not completed
> 
> Can't test on a roaming card as for now.
> local 3G doesn't have such warning, but it should have it
> (suspect foreign roaming 3G card doesn't have the warning too)

Comment 3

[skrishnan]

also can you post screen captures of the existing screen ?

Comment 4

[Walter Chen[:ypwalter][:wachen]]

The first screen on the pdf is the current showing screen.

The second screen on the pdf won't show.

The third screen on the pdf is partially the same except there is no warning for "data connection"

Comment 5

[skrishnan]

I think my changes are not there then , can you paste a link to the build that you are using to test ?

Comment 6

[Walter Chen[:ypwalter][:wachen]]

I had it in my original description:


*Phone: Unagi
2012-12-23 23:43:28
https://pvtbuilds.mozilla.org/pub/mozilla.org/b2g/nightly/date-unagi/2012/12/2012-12-21-23-43-28/

Comment 7

[skrishnan]

ok we figured that my changes have not been pushed into shira , hence the confusion , will update once done

Comment 8

[skrishnan]

they are in shira now

Comment 9

[Walter Chen[:ypwalter][:wachen]]

I checked today's shira in hg. It's not there yet. Are you sure that it works now?

Comment 10

[Walter Chen[:ypwalter][:wachen]]

Sorry, my fault. The change was in.

Waiting for pvt build so that I can change this to verified fixed.

Comment 11

[Al Tsai [:atsai]]

Reopen, please do attach commit link.

Comment 12

[Al Tsai [:atsai]]

Code landing

https://github.com/mozilla-b2g/gaia/commit/a86ee423e1c7b0855551613fa801030ce1b94b5b

Comment 13

[Joe Cheng [:jcheng] (please needinfo)]

Arthur, just want to make sure these are in v1-train/master as well. Thanks