824609 - [Open_]icons display errors（617001928162）

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Firefox_Mozilla]

User Agent: Mozilla/5.0 (Windows NT 5.1) AppleWebKit/537.1 (KHTML, like Gecko) Maxthon/4.0.0.2000 Chrome/22.0.1229.79 Safari/537.1

Steps to reproduce:

into the program list view;

build infomation:
gecko:   	 revision="3cbade1974968bb1e0fbb0c3386239715244a7a7"
gaia: 	 	 revision="aab72f365d73f624ede32b522f27d072c409e42e"
gonk-misc:   revision="654358494ba601a46ef9838debc95417ae464cc6"
dalvik:      revision="ca1f327d5acc198bb4be62fa51db2c039032c9ce"
librecovery: revision="e1bd90051c9e937221eb1f91c94e3cde747311a7"
moztt:       revision="6ee1f8987ef36d688f97064c003ad57849dfadf2"
external/jsmin:    revision="cec896f0affaa0226c02605ad28d42df1bc0e393"
external/opensans: revision="b5b4c226ca1d71e936153cf679dda6d3d60e2354"
device/qcom/b2g_common/mozilla-b2g: revision="41c17a6abfd5f488ec99d9aa246f5b07583403c7"


Actual results:

Some programs have an icon in the list, some no icons, some icon displays an error;Note: Homescreen Keyboard without icons, icon displays an error, such as Membuster,Template, was an icon of the remaining normal coupled with a name


Expected results:

all programs have an icon

Comment 1

[Al Tsai [:atsai]]

Please use the newest build and check if it happens again

Comment 2

[Firefox_Mozilla]

User version do not have is bug. It only happens in ENG version.

Comment 3

[Al Tsai [:atsai]]

Reopen the case.

We need two more icons for "Homescreen" and "System".

Comment 4

[Al Tsai [:atsai]]

Attachment: Screenshot

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

partner requested for fix. mark tracking-b2g18+. seem like a low risk change

Comment 6

[[e-mail]]

maybe we could show the 'default icon' instead, if the app icon is not specified?

Comment 7

[[e-mail]]

Attachment: app without icon will attach an default icon

Comment 8

[[e-mail]]

Attachment: Show default icon in app list if no icon is provided by manifest.webapp

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 721129 [details]
Show default icon in app list if no icon is provided by manifest.webapp

r+ but I have 2 concerns:
1. Here map icon is lost in your screenshot. Please investigate why this won't happen without the patch(see the first attachment).
2. System app and homescreen app should already have their own asserts. I don't know why they doesn't appear..

Comment 10

[[e-mail]]

Alive, thanks

at least in master:
1. Here map did not define an icon in its manifest
2. System app and homescreen app also not define icon in it's manifest

Comment 11

[(inactive after 6/18) Alive Kuo [:alive]]

Sounds like a chance to win 2 more bugs for yourself ;)

Comment 12

[[e-mail]]

merged to gaia-master
https://github.com/mozilla-b2g/gaia/commit/1b10dfc87ee6f36774635afecbbf8b6277aff986

thanks

Comment 13

[[e-mail]]

icons for homescreen and system app is 828968

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 1b10dfc87ee6f36774635afecbbf8b6277aff986 as:
v1-train: 924a853915188b2f8440ac5c9934fd1b9ab4ba44

Comment 15

[Lukas Blakk [:lsblakk] use ?needinfo]

This is already on v1.1 so does not need to block, let's get qa verification though in case there's concern it's not catching all cases.

Comment 16

[[e-mail]]

nominate to merge to 1.0.1,

the patch Show default icon in app list if no icon is provided by manifest.webapp, low risk.

Comment 17

[Johnny Stenback (:jst)]

Not blocking on this UI polish.

Comment 18

[Al Tsai [:atsai]]

Verified in v1.1 branch

===== VERSION =====
  <!-- Mercurial-Information: <project name="releases/mozilla-b2g18" path="gecko" remote="hgmozillaorg" revision="f7fc76b6fa84"/> -->
  <project name="gecko.git" path="gecko" remote="mozillaorg" revision="706cdea05057e8782dbe0b5c45c90916865bba0e"/>
  <!-- Mercurial-Information: <project name="integration/gaia-v1-train" path="gaia" remote="hgmozillaorg" revision="abe48d1c6a4a"/> -->
  <project name="gaia.git" path="gaia" remote="mozillaorg" revision="2b26d6e51d141719e548d491fa1fe9ce1bbbe8ca"/>