Closed
Bug 824636
Opened 13 years ago
Closed 13 years ago
Only show "Show dependency tree / graph" when there are blockers/dependson
Categories
(Bugzilla :: Creating/Changing Bugs, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 5.0
People
(Reporter: bugzilla-mozilla, Assigned: bugzilla-mozilla)
Details
Attachments
(2 files)
|
1.13 KB,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
|
90.68 KB,
image/png
|
Details |
Currently when displaying a bug it will always show links to show the current bug in either a tree or a graph. I think that text should be hidden until the bug depends or blocks another bug.
Reasoning (they overlap):
- Though this text indicates that the dependson/blockers can be shown as a list/graph; if there is nothing to show, this is just visual clutter
- If someone wants to figure out how to customize the list/graph, they can just go to a bug which has dependson/blockers
- The majority of bugs don't have dependson/blockers, minimizing visual noise
- Links are useless until you've saved/modified the bug, in which case the text is useful
Attachment #695652 -
Flags: review?(dkl)
| Assignee | ||
Comment 1•13 years ago
|
||
Comment 2•13 years ago
|
||
Comment on attachment 695652 [details] [diff] [review]
v1
>+ [% IF bug.depends_on_obj.size || bug.blocks_obj.size %]
It would make more sense to check bug.blocked.size and bug.dependson.size than their object equivalent. There is no need to build objects just to get the number of bugs. Fortunately, the two fields above this code already load bug objects, so we get them for free. r=LpSolit
Attachment #695652 -
Flags: review?(dkl) → review+
Updated•13 years ago
|
Flags: approval+
Target Milestone: --- → Bugzilla 5.0
Comment 3•13 years ago
|
||
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified template/en/default/bug/edit.html.tmpl
Committed revision 8565.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•