824690 - [Call log] If a contact has two phone numbers with the same type and carrier it is not possible to distinguish them on the call log

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[isabelrios]

Attachment: Call log showing calls from/to contact "Me" from different numbers

Unagi
Gaia 16006ea
Gecko cb6ee76

PROCEDURE
1. Save a contact with two phone numbers. Both numbers have the same type (Mobile) and the same carrier (movistar)
2. Receive/make several calls from/to that contact
3. Verify whether in the call log it is possible to see the entries from each number

EXPECTED
The phone number and its type should be available in the call log

ACTUAL
It is not possible to know from which number of the two that the contact has, the calls were made or received.
Please see attached screenshots

Comment 1

[isabelrios]

Attachment: contact saved with two phone numbers

Comment 2

[Germán Toro del Valle (:gtorodelvalle)]

I would say we need UX's advice here ;-) What do you think about this, Ayman?

Comment 3

[Maria Angeles Oteo (:oteo)]

I think that case is already covered in the Dialer_Contacts WF designed by Ayman(HTML5_Dialer_Contacts_20120810_R2S1_V6.0.pdf pag 11):

1) In case the call is linked to a contact the information to be shown by default for a call log entry is: The phone number type and the carrier (phone notes)

Exceptions:
- If a contact has two phone numbers with the same type and carrier (phone notes), in that case it should be displayed the following
* Phone number type and Phone Number literal.

I think it's enough info.

Comment 4

[Germán Toro del Valle (:gtorodelvalle)]

Absolutely, let me have a look at the code and adapt it if necessary... ;-) Thanks!

Comment 5

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Associated PR.

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 698921 [details] [diff] [review]
Associated PR.

Just a css change. The js included is just a nit.

a=me

Comment 7

[ayman maat :maat]

canceling RFI to me as Maria has covered this adequately in comment 3

if you need further input RFI me again

Comment 9

[amiller]

UCID: owd-1996
https://moztrap.mozilla.org/results/case/62153/

Comment 10

[Deepa Subramanian]

Verified on Unagi device Build ID: 20130115070201   using the december 5th kernel 
v 1.0.0-Prerelease