824705 - Data connection is lost on reboot if SIM PIN code is enabled

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P3)

Description

[Julien Wajsberg [:julienw]]

STR:
* have a flashed phone with a SIM Card (I use a VARIANT=user build)
* enter your PIN number
* enable the data connection in the FTU (but not WiFi to make testing easier)
* finish the FTU
=> we don't have an icon indicating that a data connection is up
* go to settings > Cellular and data
=> the "data connection" is not enabled, but it should !!
* enable the data connection preference
=> still no connection (no icon and you can try to connect somewhere in the browser)
* press "data setting"
=> no APN is configured but all available APN are shown (there really should be)
* configure your APN (Orange World for me, Sosh provider)
=> the advanced settings are filled in, which is correct
* press OK
=> the data connection preference goes off, then on, and then I have at least a working data connection

Then :
* reboot the phone
* enter your PIN number
=> no connection
* Go to settings > Cellular and data
=> "Data connection" is enabled
* Go to "Data Settings"
=> APN is not selected !!!
* if I select the correct APN then it works


This is exactly the same for A-GPS. This is also the same if I don't enable the data connection in FTU.

This is very very bad so nominating bb+.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Sosh... WFM for a regular Orange operator. I wonder if this one is related to Sosh not beeing in the apn database. If that the case (which i bet is) it is probably not a blocker.

Kaze can you confirm?

Comment 2

[Fabien Cazenave [:kaze]]

(In reply to Vivien Nicolas (:vingtetun) from comment #1)
> Sosh... WFM for a regular Orange operator. I wonder if this one is related
> to Sosh not beeing in the apn database. If that the case (which i bet is) it
> is probably not a blocker.

Sosh is an MVNO. It shares the same mcc/mnc and APN settings as Orange, so it’s auto-detected as Orange and should work out of the box.

It turns out the real issue is that Julien is using a SIM PIN code: if he disables this PIN code, everything works fine. Note that we probably have quite a few bad bugs related to this PIN code: most of the developers have disabled the PIN code on their devices months ago because the PIN unlock was too slow…

Evelyn, feel free to steal this bug if you can address it in the next couple days.

Comment 3

[Julien Wajsberg [:julienw]]

FWIW network-wise Sosh is really just like another commercial offer from Orange, it's definitely not like a MVNO (Carrefour Mobile or NRJ are MVNO, Sosh and M6 Mobile are not), that's why it shares the same mcc/mnc/apn/a-gps settings with Orange. I suspect the same bug happens with regular Orange users. I may try this with a SFR SIM if you like, I have one here as well.

Carrefour,  Tele2, etc are MVNO and have their own APN, I agree with the fact that we don't support this for v1.

Comment 4

[Fabien Cazenave [:kaze]]

Attachment: patch proposal

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch proposal 2 :)

Here is the version I got.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 696292 [details] [diff] [review]
patch proposal

As said IRL there is still an issue if you customize your APN. It is reset to default every time you reboot the device.

Comment 7

[Fabien Cazenave [:kaze]]

Attachment: patch proposal

https://github.com/mozilla-b2g/gaia/pull/7232

I’m afraid I’ve re-written most of the operator_variant.js file… it was a bit too confusing for me. With this patch we have:
 • one global `iccSettings' object that holds the last known mcc/mnc values (from the SIM card iccInfo) as integers;
 • one main `checkICCInfo()' function that compares these mcc/mnc with the current iccInfo mcc/mnc values from the SIM card, and applies new APN settings if they differ.

I hope it makes the code more readable. It seems to work here but I'll do some further tests in an hour (getting out of my train at the moment…).

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Fabien Cazenave [:kaze] from comment #7)
> Created attachment 696340 [details]
> patch proposal
> 
> https://github.com/mozilla-b2g/gaia/pull/7232
> 
> I’m afraid I’ve re-written most of the operator_variant.js file… it was a
> bit too confusing for me. With this patch we have:
>  • one global `iccSettings' object that holds the last known mcc/mnc values
> (from the SIM card iccInfo) as integers;
>  • one main `checkICCInfo()' function that compares these mcc/mnc with the
> current iccInfo mcc/mnc values from the SIM card, and applies new APN
> settings if they differ.
> 
> I hope it makes the code more readable. It seems to work here but I'll do
> some further tests in an hour (getting out of my train at the moment…).

I made some comments on github.

Comment 9

[Fabien Cazenave [:kaze]]

Comment on attachment 696340 [details]
patch proposal

Spent an hour testing, everything looks OK — including when the data connection is first enabled in the FTU.

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/640173df94473e32cce8e2756731231d3c129681