824706 - [pt-BR] The digital clock does not appear.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P2)

Description

[Nicolas B. Pierron [:nbp]]

Attachment: exhibit 1

The digital clock of the homescreen and lockscreen visible in English and French localization does not appear with the português local.

STR:
 - Go to settings
 - Tap Language
 - Tap on Language drop down menu
 - Tap on Português (do Brasil)
 - Tap on the home button

Expected:
 - A digital clock with the date under it.

Seen: (see exhibit 1)
 - Only the date appear, not the digital clock.

Device info:
 - OS: 1.0.0
 - Hardware: nice
 - Platform: 18.0
 - Build id: 20121212102240
 - Channel: beta
 - Git info: 2012-12-12 15:11:48  (unknown sha1)

Comment 1

[David Scravaglieri [:scravag]]

Is it reproducible on recent build ?

Comment 2

[Dylan Oliver [:doliver]]

Reproduced on 12/25 and 12/26 nightly builds, blocking+.

Comment 3

[[e-mail], [e-mail]]

Hi Stas,
It looks like an localized string issue.
We could refer https://github.com/mozilla-b2g/gaia/blob/master/shared/locales/date/date.en-US.properties#L139 .
shortTimeFormat = %I:%M %p

But the same id of date.pt-BR.properties is:
shortTimeFormat = %Hh%M

When the code run to https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/landing.js#L62 with the localized string, it will return null.
So, the digital clock of the homescreen and lockscreen are invisible in português local.
We can see a strange digital clock of the status bar too.

The mapping string should be |%H:%M|.
I think the character "h" could be a mistake.

Since we cannot access the file(date.pt-BR.properties) in Gaia repository, could you please help to revise it?

Thank you.

Comment 4

[Axel Hecht [:Pike]]

The date formats refer to http://pubs.opengroup.org/onlinepubs/007908799/xsh/strftime.html as the legal patterns, and I think that 14h54 is a perfectly fine way to format a date for a user, if that's the local custom.

If we're only allowing some limited customization for the short date format on the clock, we probably shouldn't over-use the shortTimeFormat at all. Or be smarter in using it. I can't figure out ad-hoc what the code is trying to get out of the localization here, tbh.

I'm moving this to the gaia:clock app, as I consider this to be a bug in the clock application and how it uses the shortTimeFormat string.

Comment 5

[Nicolas B. Pierron [:nbp]]

The clock application does not even show the SVG animation, only the alarm button on the top right corner appear.

Comment 6

[Fabien Cazenave [:kaze]]

(In reply to Axel Hecht [:Pike] from comment #4)
> I think that 14h54 is a perfectly fine way to format a
> date for a user, if that's the local custom.

True. This time format should be supported as well.

> I'm moving this to the gaia:clock app, as I consider this to be a bug in the
> clock application and how it uses the shortTimeFormat string.

Moving back to Gaia, as the Clock app is a very different thing.

(In reply to Nicolas B. Pierron [:pierron] [:nbp] from comment #5)
> The clock application does not even show the SVG animation, only the alarm
> button on the top right corner appear.

It’s not related to the current issue, so please file a new bug for that.

Comment 7

[Fabien Cazenave [:kaze]]

Attachment: patch proposal

Comment 8

[Nicolas B. Pierron [:nbp]]

Comment on attachment 696054 [details] [diff] [review]
patch proposal

Review of attachment 696054 [details] [diff] [review]:
-----------------------------------------------------------------

Is that a good assumption for people from the MIB which are doing day of more than 30 hours? (joke inside)

Comment 9

[Fabien Cazenave [:kaze]]

(In reply to Nicolas B. Pierron [:pierron] [:nbp] from comment #8)
> Is that a good assumption for people from the MIB which are doing day of
> more than 30 hours? (joke inside)

Agreed, but they’re not part of the basecamp locales so I think it’s OK. ;-)

Comment 10

[Fabien Cazenave [:kaze]]

https://github.com/mozilla-b2g/gaia/commit/16fefd448f44007182632e3f2fc1a2ab38ae3831

Comment 11

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Removing Qawanted, looks like dylan answered his own question.