NSPR shouldn't require librt

RESOLVED FIXED in 4.9.5

Status

P1
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: bholley, Assigned: glandium)

Tracking

other
4.9.5

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
This breaks x86 B2G emulator-x86 builds. Glandium says that this shouldn't be there - there's no librt on android.
(Reporter)

Comment 1

6 years ago
Created attachment 695786 [details] [diff] [review]
patch v1

This fixes it for me. No idea if it's correct.
Attachment #695786 - Flags: feedback?(mh+mozilla)
(Assignee)

Comment 2

6 years ago
Comment on attachment 695786 [details] [diff] [review]
patch v1

Review of attachment 695786 [details] [diff] [review]:
-----------------------------------------------------------------

I guess the right fix would be to test where clock_gettime can be found, like in gecko configure.in, and use that.
But sure enough, that should work, too.
Attachment #695786 - Flags: feedback?(mh+mozilla)
(Reporter)

Updated

6 years ago
Attachment #695786 - Flags: review?(wtc)
(Assignee)

Comment 3

6 years ago
Comment on attachment 695786 [details] [diff] [review]
patch v1

In fact, I have the opposite problem on GNU/kfreebsd, so it would just be better to import the test from m-c. I'll do it.
Attachment #695786 - Flags: review?(wtc)
(Assignee)

Comment 4

6 years ago
(In reply to Mike Hommey [:glandium] from comment #3)
> Comment on attachment 695786 [details] [diff] [review]
> patch v1
> 
> In fact, I have the opposite problem on GNU/kfreebsd, so it would just be
> better to import the test from m-c. I'll do it.

In fact, that opens a too big can of worms :(
(Assignee)

Comment 5

6 years ago
Created attachment 696475 [details] [diff] [review]
Use -lrt appropriately (or not) on Android, GNU/Hurd and GNU/kFreeBSD

For wtc or ted, whoever comes here first.
Attachment #696475 - Flags: review?(wtc)
Attachment #696475 - Flags: review?(ted)
(Assignee)

Updated

6 years ago
Assignee: wtc → mh+mozilla
(Assignee)

Updated

6 years ago
Attachment #695786 - Attachment is obsolete: true
Attachment #696475 - Flags: review?(ted) → review+
(Assignee)

Comment 6

6 years ago
Comment on attachment 696475 [details] [diff] [review]
Use -lrt appropriately (or not) on Android, GNU/Hurd and GNU/kFreeBSD

Ted, could you land this on nspr trunk?
Attachment #696475 - Flags: review?(wtc)
Checking in pr/src/Makefile.in;
/cvsroot/mozilla/nsprpub/pr/src/Makefile.in,v  <--  Makefile.in
new revision: 1.65; previous revision: 1.64
done
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Version: other → 4.9.5

Updated

6 years ago
Priority: -- → P1
Target Milestone: --- → 4.9.5
Version: 4.9.5 → other
You need to log in before you can comment on or make changes to this bug.