Do not try to make a bango number premium twice (payment registration)

RESOLVED FIXED in 2012-12-27

Status

Marketplace
Payments/Refunds
P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kumar, Assigned: andym)

Tracking

2012-12-27
x86
Mac OS X
Points:
---

Details

STR:
1. Upload an app and enable payments
2. Associate the app with an account and save
3. Go back to the same screen and click save a second time on that app

The code is trying to call the make-premium Bango API on a number that is already premium. This is unnecessary and results in an error like:

s.client:ERROR Solitude error with https://payments-dev.allizom.org/bango/premium/: u'{"error_code": "<type \'type\'>", "error_data": {}, "error_message": "<type \'type\'>: The specified Bango Number is already enabled for premium billing"}' :/data/www/addons-dev.allizom.org/zamboni/lib/pay_server/base.py:126

The devhub screen says: We encountered a problem connecting to the payment server.
Assignee: nobody → kumar.mcmillan
Blocks: 775802
Priority: -- → P1
Target Milestone: --- → 2013-01-03

Comment 1

5 years ago
Note that this also blocks users from doing any changes to their price tier/currency or bank account selection.
(Assignee)

Comment 2

5 years ago
Premium doesn't change anything in the solitude database, because it doesn't return any new data. I would if we should record that it did run successfully.
(Assignee)

Updated

5 years ago
Assignee: kumar.mcmillan → amckay
Thanks Andy. This is working for me now.

https://github.com/mozilla/solitude/commit/854187f13e6b4fc01332646dda25607a58f96d12
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: 2013-01-03 → 2012-12-27
You need to log in before you can comment on or make changes to this bug.