824765 - [traceback] AttributeError: 'NoneType' object has no attribute 'price'

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect)

Description

[krupa raj[:krupa]]

pre-condition: Tester has bank accounts associated with their test account.

steps to reproduce:
1. Submit a new paid app
2. After completing submission, navigate to the Compatibility & Payments page
3. Leaving the default payment tier as is, select currency = EUR and a bank account
4. Save changes.

traceback details:
Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "amo/decorators.py", line 160, in wrapper
    return f(*args, **kw)
  File "amo/decorators.py", line 152, in wrapper
    return f(*args, **kw)
  File "addons/decorators.py", line 33, in wrapper
    return f(request, addon, *args, **kw)
  File "amo/decorators.py", line 33, in wrapper
    return func(request, *args, **kw)
  File "mkt/developers/decorators.py", line 49, in wrapper
    return fun()
  File "mkt/developers/decorators.py", line 28, in <lambda>
    *args, **kw)
  File "mkt/developers/views_payments.py", line 65, in payments
    bango_account_list_form.save()
  File "mkt/developers/forms_payments.py", line 368, in save
    payment_account=self.cleaned_data['accounts'])
  File "mkt/developers/models.py", line 198, in create
    set_price=addon.premium.price.price,

Comment 1

[Kumar McMillan [:kumar]]

This was a bug I ran into and fixed. I'm pretty sure the error is because you created one of the bank accounts before I fixed the bug. Can you try it with a new account? When I can figure out where the db is I can clean out your old bank account data.

Comment 2

[Kumar McMillan [:kumar]]

I meant can you try it using a brand new persona login that you previously had not created any bank accounts with?

Comment 3

[krupa raj[:krupa]]

(In reply to Kumar McMillan [:kumar] from comment #2)
> I meant can you try it using a brand new persona login that you previously
> had not created any bank accounts with?

will do so.

Comment 4

[krupa raj[:krupa]]

okay. So, i tried with a new account and was still able to hit this traceback.

SUre way to reproduce this bug is to pick "Paid" during app submission.

Comment 5

[Kumar McMillan [:kumar]]

I can reproduce this locally now.

Comment 6

[Kumar McMillan [:kumar]]

This is fixed now: https://github.com/mozilla/zamboni/commit/31c1276425ad6402856c56de92b857673bedba45

However, you cannot test this with any existing paid apps or else you'll hit bug 824751. You need to create a new paid app and associate it to a bank account (can be an existing account).

Comment 7

[krupa raj[:krupa]]

This works fine now.