Refactor SocialToolbar.updateButton to multiple smaller functions

RESOLVED WONTFIX

Status

()

Firefox
SocialAPI
RESOLVED WONTFIX
5 years ago
4 years ago

People

(Reporter: jaws, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(In reply to Matthew N. [:MattN] from bug 811835 comment #16)
> ::: browser/base/content/browser-social.js
> @@ +780,5 @@
> >      this.updateButtonHiddenState();
> >      let provider = Social.provider;
> >      let icons = provider.ambientNotificationIcons;
> >      let iconNames = Object.keys(icons);
> > +    let socialToolbarItem = document.getElementById("social-toolbar-item");
> 
> This function is way too large.  It should be refactored into more
> manageable pieces in a separate bug.
obsoleted by bug 935640
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.