824929 - [SIM screen] The Done key is always active and can be pressed before the PIN Code is introduced

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[isabelrios]

Unagi Test Run 1
Gaia 16006ea
Geck cb6ee76
PROCEDURE
 1. Turn on the device using a SIM Card with PIN
 2. Before introducing the PIN Code, click on Done key

EXPECTED
 Done key should be disabled until user introduces the PIN Code

ACTUAL
 The Done key can be clicked with no PIN inserted. The behaviour of this key is the same no matter if the PIN has been introduced

Comment 1

[Fernando Campo (:fcampo)]

Right now we have a check on length of the pin input when pressing Done, but being always enabled is part of the code.

Asking UX for confirmation about the expected behaviour.

Comment 2

[Victoria Gerchinhoren [:vicky]]

Agree with Isabel, it should be disabeled until reaching the mimimum of characters accepted to confirm if the pin is valid.

Comment 3

[Fernando Campo (:fcampo)]

how do we make the user aware of the reason why the button is disabled? Add the information (PIN code must be between 4 and 8 characters) to the input label? Show the error till the minimum is reached?

Should we disable the button also if the max number (8) is reached? Or just not let the user to write more than 8 on the input field?

Comment 4

[isabelrios]

Testrun 5.1. Test case  #5046

Comment 5

[Chris Kreinbring [:CKreinbring]]

Also seen on the Buri 1.2 mozilla RIL.  The Send button is enabled despite nothing in the textbox.

Build ID: 20131003004003
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/7dfe4a775531
Gaia: 9e21b6bea92fdafcb6787120a8cde0eb25a50495
Platform Version: 26.0a2

Comment 6

[Fernando Campo (:fcampo)]

This fell out of the radar completely, I see questions unanswered, so I'll try to give it a spin

Comment 7

[Fernando Campo (:fcampo)]

Attachment: Link to PR - https://github.com/mozilla-b2g/gaia/pull/12710

Comment 8

[Jose Manuel Cantera]

Comment on attachment 814126 [details] [review]
Link to PR - https://github.com/mozilla-b2g/gaia/pull/12710

provided the last nit on GH is solved

Comment 9

[Fernando Campo (:fcampo)]

merged on master https://github.com/mozilla-b2g/gaia/commit/907a8656e49599d334203c22dcbdb3f98c1d7864

Thanks for the review. Asking for approval v1.2

Comment 10

[Fernando Campo (:fcampo)]

Attachment: Asking for approval for 1.2

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: user will be able to press Done button without a pin introduced, and then see an error message. We can avoid this with the patch.
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky): low risk, mostly a visual change
[String changes made]:

Comment 11

[Noemí Freire (:noemi)]

Hi John,

how should we proceed in order to uplift this patch to 1.2 branch?. Thanks!

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

[v1.2 94c8d4f] Merge pull request #12710 from fcampo/ftu-doneButton-824929

Comment 13

[isabelrios]

Verified on 10/29 v1.2 build:
Gecko-76298d3
Gaia-2ad6152

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 907a8656e49599d334203c22dcbdb3f98c1d7864 to:
v1.3 already had this commit