Closed Bug 824947 Opened 10 years ago Closed 8 years ago

Put the add-on installation progress notification's custom content in <popupnotificationcontent> rather than overriding the anonymous content

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal
Points:
3

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 39
Iteration:
39.3 - 30 Mar
Tracking Flags:
Tracking Status
firefox39 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file, 1 obsolete file)

patch
9.59 KB, patch
mossop
: review+
Details | Diff | Splinter Review
Attached patch patch (obsolete) — — Splinter Review 
We should really get rid of urlbarBindings.xml#addon-progress-notification entirely and put that code somewhere in browser-addons.js. Only doing the first step here, though.
Attachment #696022 - Flags: review?(bmcbride)
Comment on attachment 696022 [details] [diff] [review]
patch

Review of attachment 696022 [details] [diff] [review]:
-----------------------------------------------------------------

Punting review to Dave (I'm still mostly on leave, and Dave knows this stuff far better anyway).
Attachment #696022 - Flags: review?(bmcbride) → review?(dtownsend+bugmail)
How does this work for the case where there are multiple progress notifications?
(In reply to Dave Townsend (:Mossop) from comment #2)
> How does this work for the case where there are multiple progress
> notifications?

I didn't know we support that. I suppose my patch breaks this.
Attachment #696022 - Flags: review?(dtownsend+bugmail)
Attached patch patch — — Splinter Review 
We don't allow having multiple notifications with the same id for one tab, so this should be fine.
Attachment #696022 - Attachment is obsolete: true
Attachment #8584724 - Flags: review?(dtownsend)
Attachment #8584724 - Flags: review?(dtownsend) → review+
https://hg.mozilla.org/mozilla-central/rev/230000accfbe
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Iteration: --- → 39.3 - 30 Mar
Points: --- → 3
Flags: qe-verify-
Flags: firefox-backlog+
You need to log in before you can comment on or make changes to this bug.