824947 - Put the add-on installation progress notification's custom content in <popupnotificationcontent> rather than overriding the anonymous content

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

We should really get rid of urlbarBindings.xml#addon-progress-notification entirely and put that code somewhere in browser-addons.js. Only doing the first step here, though.

Comment 1

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 696022 [details] [diff] [review]
patch

Review of attachment 696022 [details] [diff] [review]:
-----------------------------------------------------------------

Punting review to Dave (I'm still mostly on leave, and Dave knows this stuff far better anyway).

Comment 2

[Dave Townsend [:mossop]]

How does this work for the case where there are multiple progress notifications?

Comment 3

[Dão Gottwald [:dao]]

(In reply to Dave Townsend (:Mossop) from comment #2)
> How does this work for the case where there are multiple progress
> notifications?

I didn't know we support that. I suppose my patch breaks this.

Comment 4

[Dão Gottwald [:dao]]

Attachment: patch

We don't allow having multiple notifications with the same id for one tab, so this should be fine.

Comment 5

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/fx-team/rev/230000accfbe

Comment 6

[Nick Alexander :nalexander [he/him] (PTO August 22-September 12)]

https://hg.mozilla.org/mozilla-central/rev/230000accfbe