Closed
Bug 824947
Opened 12 years ago
Closed 9 years ago
Put the add-on installation progress notification's custom content in <popupnotificationcontent> rather than overriding the anonymous content
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file, 1 obsolete file)
|
9.59 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
We should really get rid of urlbarBindings.xml#addon-progress-notification entirely and put that code somewhere in browser-addons.js. Only doing the first step here, though.
Attachment #696022 -
Flags: review?(bmcbride)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 696022 [details] [diff] [review] patch Review of attachment 696022 [details] [diff] [review]: ----------------------------------------------------------------- Punting review to Dave (I'm still mostly on leave, and Dave knows this stuff far better anyway).
Attachment #696022 -
Flags: review?(bmcbride) → review?(dtownsend+bugmail)
|
||
Comment 2•11 years ago
|
||
How does this work for the case where there are multiple progress notifications?
|
Assignee | |
Comment 3•11 years ago
|
||
(In reply to Dave Townsend (:Mossop) from comment #2) > How does this work for the case where there are multiple progress > notifications? I didn't know we support that. I suppose my patch breaks this.
|
|
Assignee | |
Updated•11 years ago
|
Attachment #696022 -
Flags: review?(dtownsend+bugmail)
|
|
Assignee | |
Comment 4•9 years ago
|
||
We don't allow having multiple notifications with the same id for one tab, so this should be fine.
Attachment #696022 -
Attachment is obsolete: true
Attachment #8584724 -
Flags: review?(dtownsend)
|
|
||
Updated•9 years ago
|
Attachment #8584724 -
Flags: review?(dtownsend) → review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/230000accfbe
|
||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/230000accfbe
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
|
|
Assignee | |
Updated•9 years ago
|
Iteration: --- → 39.3 - 30 Mar
Points: --- → 3
Flags: qe-verify-
Flags: firefox-backlog+
You need to log in
before you can comment on or make changes to this bug.
Description
•