If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Put the add-on installation progress notification's custom content in <popupnotificationcontent> rather than overriding the anonymous content

RESOLVED FIXED in Firefox 39

Status

()

Firefox
General
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 39
Points:
3
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 696022 [details] [diff] [review]
patch

We should really get rid of urlbarBindings.xml#addon-progress-notification entirely and put that code somewhere in browser-addons.js. Only doing the first step here, though.
Attachment #696022 - Flags: review?(bmcbride)
Comment on attachment 696022 [details] [diff] [review]
patch

Review of attachment 696022 [details] [diff] [review]:
-----------------------------------------------------------------

Punting review to Dave (I'm still mostly on leave, and Dave knows this stuff far better anyway).
Attachment #696022 - Flags: review?(bmcbride) → review?(dtownsend+bugmail)
How does this work for the case where there are multiple progress notifications?
(Assignee)

Comment 3

5 years ago
(In reply to Dave Townsend (:Mossop) from comment #2)
> How does this work for the case where there are multiple progress
> notifications?

I didn't know we support that. I suppose my patch breaks this.
(Assignee)

Updated

5 years ago
Attachment #696022 - Flags: review?(dtownsend+bugmail)
(Assignee)

Comment 4

3 years ago
Created attachment 8584724 [details] [diff] [review]
patch

We don't allow having multiple notifications with the same id for one tab, so this should be fine.
Attachment #696022 - Attachment is obsolete: true
Attachment #8584724 - Flags: review?(dtownsend)
Attachment #8584724 - Flags: review?(dtownsend) → review+
(Assignee)

Comment 5

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/230000accfbe
https://hg.mozilla.org/mozilla-central/rev/230000accfbe
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
(Assignee)

Updated

3 years ago
Iteration: --- → 39.3 - 30 Mar
Points: --- → 3
Flags: qe-verify-
Flags: firefox-backlog+
You need to log in before you can comment on or make changes to this bug.