verify format of desktop releases' changesets file

RESOLVED FIXED

Status

Release Engineering
Release Automation
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: bhearsum, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [shipit])

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
We do this for the mobile JSON changesets, but don't have a similar check for Firefox
(Assignee)

Comment 1

5 years ago
Created attachment 696337 [details] [diff] [review]
separate plain text changesets parsing into a function

With tests!
Attachment #696337 - Flags: review?(catlee)
(Assignee)

Comment 2

5 years ago
Created attachment 696338 [details] [diff] [review]
verify changesets upon submission
Attachment #696338 - Flags: review?(catlee)

Updated

5 years ago
Attachment #696337 - Flags: review?(catlee) → review+

Updated

5 years ago
Attachment #696338 - Flags: review?(catlee) → review+
(Assignee)

Comment 3

5 years ago
Landed in http://git.mozilla.org/?p=build/release-kickoff.git;a=commit;h=2f372f772acf6737691b96502fb797fdc8584bd3.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Attachment #696338 - Flags: checked-in+
(Assignee)

Updated

5 years ago
Attachment #696337 - Flags: checked-in+
(Assignee)

Updated

5 years ago
Whiteboard: [kickoff] → [shipit]
Product: mozilla.org → Release Engineering
Comment on attachment 696337 [details] [diff] [review]
separate plain text changesets parsing into a function

Review of attachment 696337 [details] [diff] [review]:
-----------------------------------------------------------------

Just found a (very small) bug in this patch...

Pete

::: lib/python/release/l10n.py
@@ +61,3 @@
>              if revision == 'FIXME':
>                  raise Exception('Found FIXME in %s for locale "%s"' % \
>                                  (fileName, locale))

The variable "fileName" (above) no longer exists, because the function definition changed from:

getL10nRepositories(fileName, l10nRepoPath, relbranch=None)
to
getL10nRepositories(changesets, l10nRepoPath, relbranch=None)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Opened bug 937175 for this issue instead.
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.