releases on release kickoff need to be editable or deletable via the web

RESOLVED FIXED

Status

Release Engineering
Release Automation: Other
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: bhearsum, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [shipit])

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
We hit issues sometimes where the wrong data is entered into release kickoff. Currently, the only way to fix this is to correct the data directly in the DB, or delete the entry directly via the db and try again. We need some way to cope with these situations without db access.
(Assignee)

Comment 1

6 years ago
Created attachment 696776 [details] [diff] [review]
make releases deleteable

This implements release deletion for releases that aren't marked as complete or ready.
Assignee: nobody → bhearsum
Status: NEW → ASSIGNED
Attachment #696776 - Flags: review?(rail)
Comment on attachment 696776 [details] [diff] [review]
make releases deleteable

lgtm
Attachment #696776 - Flags: review?(rail) → review+
(Assignee)

Comment 3

5 years ago
Created attachment 697444 [details] [diff] [review]
make releases editable

A bunch of this patch is refactoring, namely:
* Moving forms to a common file
* Moving form rendering to an includeable template

The rest is new code + tests + templates to make releases editable. Note that any release that is ready or complete is NOT editable. This is enforced by not giving out links to the edit form for these releases, refusing to render the page if the link was manually constructed, and also by returning a 403 if someone tries to manually POST an edit to such a release.
Attachment #697444 - Flags: review?(rail)
Comment on attachment 697444 [details] [diff] [review]
make releases editable

       _~
    _~ )_)_~
    )_))_))_)    it!
    _!__!__!_
    \______t/
  ~~~~~~~~~~~~~
Attachment #697444 - Flags: review?(rail) → review+
(Assignee)

Updated

5 years ago
Attachment #697444 - Flags: checked-in+
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Whiteboard: [kickoff] → [shipit]
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.