824980 - releases on release kickoff need to be editable or deletable via the web

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[[e-mail] (:bhearsum)]

We hit issues sometimes where the wrong data is entered into release kickoff. Currently, the only way to fix this is to correct the data directly in the DB, or delete the entry directly via the db and try again. We need some way to cope with these situations without db access.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: make releases deleteable

This implements release deletion for releases that aren't marked as complete or ready.

Comment 2

[Rail Aliiev [:rail]]

Comment on attachment 696776 [details] [diff] [review]
make releases deleteable

lgtm

Comment 3

[[e-mail] (:bhearsum)]

Attachment: make releases editable

A bunch of this patch is refactoring, namely:
* Moving forms to a common file
* Moving form rendering to an includeable template

The rest is new code + tests + templates to make releases editable. Note that any release that is ready or complete is NOT editable. This is enforced by not giving out links to the edit form for these releases, refusing to render the page if the link was manually constructed, and also by returning a 403 if someone tries to manually POST an edit to such a release.

Comment 4

[Rail Aliiev [:rail]]

Comment on attachment 697444 [details] [diff] [review]
make releases editable

       _~
    _~ )_)_~
    )_))_))_)    it!
    _!__!__!_
    \______t/
  ~~~~~~~~~~~~~

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 696776 [details] [diff] [review]
make releases deleteable

Landed both of these in http://git.mozilla.org/?p=build/release-kickoff.git;a=commit;h=2f372f772acf6737691b96502fb797fdc8584bd3.