Closed Bug 824994 Opened 8 years ago Closed 8 years ago

Hide the marketplace promo if the user has visited the marketplace before.

Categories

(Firefox for Android :: General, defect)

x86
Linux
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 21

People

(Reporter: wesj, Assigned: wesj)

Details

Attachments

(1 file)

about:home looks so much cleaner without the promo on it. Right now that can never happen :( If someone's gone to the marketplace, whether they loved it or not, no reason to keep showing this.
Attached patch PatchSplinter Review
This turned into a semi refactor of this stuff. Basically the promo box now contains a list of possible promos. When showRandom() is called, it loops through the list (on a background thread) and calls canShow() on each item to build a list of available items. Then it randomly picks something from that and shows it.

This should make it easier to add new promo types if we want. And also moved some code out of AboutHomeContent that had no business being there.
Attachment #700549 - Flags: review?(mark.finkle)
ping?
Comment on attachment 700549 [details] [diff] [review]
Patch

>diff --git a/mobile/android/base/AboutHomePromoBox.java b/mobile/android/base/AboutHomePromoBox.java

>+    public static class Type {
>+        public int title;
>+        public int boldName;

Just some naming tweaks: title -> text and boldName -> boldText

This is a nice refactor.

r+, with the name tweaks. I can make those and land.
Attachment #700549 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/e93f506bc784
Assignee: nobody → wjohnston
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
Verified fixed on:
-build:  Firefox for Android 21.0a1 (2013-02-15)
-device: Samsung Galaxy Tab 2 7.0
-OS: Android 4.0.4
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.