824994 - Hide the marketplace promo if the user has visited the marketplace before.

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

about:home looks so much cleaner without the promo on it. Right now that can never happen :( If someone's gone to the marketplace, whether they loved it or not, no reason to keep showing this.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

This turned into a semi refactor of this stuff. Basically the promo box now contains a list of possible promos. When showRandom() is called, it loops through the list (on a background thread) and calls canShow() on each item to build a list of available items. Then it randomly picks something from that and shows it.

This should make it easier to add new promo types if we want. And also moved some code out of AboutHomeContent that had no business being there.

Comment 2

[Wesley Johnston (:wesj)]

ping?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 700549 [details] [diff] [review]
Patch

>diff --git a/mobile/android/base/AboutHomePromoBox.java b/mobile/android/base/AboutHomePromoBox.java

>+    public static class Type {
>+        public int title;
>+        public int boldName;

Just some naming tweaks: title -> text and boldName -> boldText

This is a nice refactor.

r+, with the name tweaks. I can make those and land.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e93f506bc784

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e93f506bc784

Comment 6

[Andreea Pod]

Verified fixed on:
-build:  Firefox for Android 21.0a1 (2013-02-15)
-device: Samsung Galaxy Tab 2 7.0
-OS: Android 4.0.4