Show compatibility error if an add-on uses setAndLoadFaviconForPage

VERIFIED FIXED in 2013-01-03

Status

VERIFIED FIXED
6 years ago
3 years ago

People

(Reporter: jorgev, Assigned: basta)

Tracking

unspecified
2013-01-03

Details

(Whiteboard: [fx18])

(Reporter)

Description

6 years ago
As explained in bug 741059, the setAndLoadFaviconForPage function has changed and has an additional argument. We need to flag all instances of these function calls and show an error.

This is a compatibility error, so the add-on should not be upgraded in this case.

Message:

The setAndLoadFaviconForPage function have changed to support per-window private browsing. You should now pass a load type as an additional argument. See <LINK> for more information.

Link: https://bugzilla.mozilla.org/show_bug.cgi?id=741059

Affected add-on:

https://addons.mozilla.org/firefox/addon/bmreplace/
(Assignee)

Comment 1

6 years ago
Merged:

https://github.com/mozilla/amo-validator/commit/c068bfd5b0ef2e49243c3d16d860de1e4741e787
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 2

6 years ago
verified fixed at https://addons-dev.allizom.org/en-US/developers/upload/907a01bc67ae48e29343b1533ae4c5bc
Status: RESOLVED → VERIFIED

Updated

6 years ago
Blocks: 833512
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.