825016 - fennec - hitting back from a tab opened by tabs.open, minimizes fennec

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Jeff Griffiths (:canuckistani) (:⚡︎)]

I've cobbled together a mobile add-on example that, adds some menu and context menu items to fennec:

https://github.com/canuckistani/fennec-plus/

If I open a page using tabs.open, then hit the android back button the Fennec window closes even if other tabs are open.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Unassigning myself from bugs I haven't gotten around to

Comment 2

[Jan Henning [:JanH]]

Attachment: Pull request

Comment 3

[Jan Henning [:JanH]]

Attachment: MozReview Request: Bug 825016 - Part 1 - When opening a new tab, pass the ID of the parent tab. r=zer0

This ensures that when hitting back, we return to the previously opened tab.

Review commit: https://reviewboard.mozilla.org/r/45529/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45529/

Comment 4

[Jan Henning [:JanH]]

This is simply matching what Fennec does internally in browser.js (https://dxr.mozilla.org/mozilla-central/rev/29d5a4175c8b74f45482276a53985cf2568b4be2/mobile/android/chrome/content/browser.js#600).

I've also got a potential test, but since don't know how to actually run the tests on Android (mach mochitest doesn't work), I've no idea whether it actually works or not.

Comment 5

[Jan Henning [:JanH]]

Comment on attachment 8740063 [details]
MozReview Request: Bug 825016 - Part 1 - When opening a new tab, pass the ID of the parent tab. r=zer0

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/45529/diff/1-2/

Comment 6

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 8740063 [details]
MozReview Request: Bug 825016 - Part 1 - When opening a new tab, pass the ID of the parent tab. r=zer0

https://reviewboard.mozilla.org/r/45529/#review45511

Looks good to me!

Comment 7

[Jan Henning [:JanH]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=65f9cfd407eb

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/0f700af8dbaf

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0f700af8dbaf