825046 - [Gaia][Gallery] Delete Video does not work correctly

Status: VERIFIED WORKSFORME

(Firefox OS Graveyard :: Gaia::Gallery, defect, P3)

Description

[Ralph Daub [:rdaub]]

ENVIRONMENT:
Unagi phone, build 12/27


STEPS to REPRO:
1. Open up Gallery
2. Tap on the trashcan icon to delete video
3. Tap "OK" to confirm delete video


EXPECTED:
Video should be deleted instantly, and the next picture/video in the gallery should be shown.


ACTUAL:
1. The video remains visible and playable in the gallery.

2. Tapping the Home button, then opening up the gallery:
   the video remains visible and playable.

3. Force-closing the gallery (Holding the Home button, then swiping up the gallery):
   the gallery icons are reloaded, and the video is deleted.

Thanks!!

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Basically the video as well as gallery app are caching the information somewhere and not refreshing is what I am guessing?  cc'ing David Flanagan

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Another case of this would be to open the gallery or video app, add stuff to the sdcard and then look at the gallery and video app for the newly added files.  They won't be seen.

Comment 3

[Ralph Daub [:rdaub]]

Possibly related to bug 821912

Comment 4

[Joe Cheng [:jcheng] (please needinfo)]

Triage: BB+, C4, P3 - delete function not work

Comment 5

[David Flanagan [:djf]]

Attachment: link to patch on github

This bug was caused by a copy/paste error, to the fix is just one line long.
Should be easy to review :-)

Comment 6

[James Lal [:lightsofapollo]]

Comment on attachment 696587 [details]
link to patch on github

Typo fix ( I checked media db source) looks good to me...

Comment 7

[James Lal [:lightsofapollo]]

https://github.com/mozilla-b2g/gaia/commit/db9d8ab671b192445f12f3e6d436ca76affed0e2

Comment 10

[mlevin]

Attachment: Thumbnails appear after deleting a video

Issue persists on Unagi Build 20121231070201. After deleting the video a gray thumbnail is seen in Gallery where the video used to be.

Comment 11

[David Flanagan [:djf]]

Shoot. The dreaded gray thumbnail issue.  I would expect gray thumbnails to appear only at the very bottom or top of the thumbnail list. Is that what you see?  Can you get the same gray thumbnail to appear when deleting a photo?

Comment 12

[mlevin]

The issue I am seeing now that appears to be reproducible, is that the thumbnail of the photo or video is still visible in Gallery after deleting them from the Select screen and then going back to Gallery. If you end task the Gallery and then re-open Gallery you then see the photo or video thumbnail for about 5-10 seconds, then it disappears. This on Unagi Build 20121231070201.

Comment 13

[David Flanagan [:djf]]

I can't reproduce this. 

mlevin: in the screenshot you attached, the blue 'marching ants' progress indicator is visible, which indicates that the gallery is still scanning for new photos.

Can you reproduce this when the phone is not scanning?  And also, do the gray squares go away when the scanning process is complete?

If this bug only occurs when deleting files while scanning is going on, then:

a) it is probably harder to fix

b) it is less likely to affect users and maybe shouldn't be blocking.

If you can still reproduce it, could you give more precises steps to reproduce?

Comment 14

[mlevin]

Issue seems to be fixed on Unagi build 20130102070202. In other words after deleting the video from the Select screen and going back to Gallery thumbnail view the thumbnail does not appear. Going to resolve this bug.

Comment 15

[Deepa Subramanian]

Bug seems to be fixed. Verified on Unagi Build ID: 201302011070202
Kernel: Dec 5
Gecko:http://hg.mozilla.org/releases/mozilla-b2g18/rev/59fbbbbba801
Gaia:21cedfd1787f4aff26721fc0f160e771db5cd67d