825049 - Wi-Fi hotspot fails if password contains space

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Brion Vibber]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:20.0) Gecko/20121223 Firefox/20.0
Build ID: 20121223030832

Steps to reproduce:

Enabling WiFi sharing on my unagi test device works great as long as the password does not contain spaces.

No problems with passwords '0123456789' or 'wiresAteMyBrain' or 'wires-AteMyBrain' but 'wires AteMyBrain' or 'wires Ate My Brain' fail.

Tested a Mac OS X machine and a Nexus 7 tablet as clients.


Actual results:

When password has a space, FirefoxHotspot just doesn't show up in networks available on client machines.


Expected results:

Hotspot should be available just as with passwords not containing spaces.

Seems same for WPA and WPA2... and even when setting as 'open'.

Comment 1

[Vincent Chang[:vchang][changyihsin]]

Attachment: Patch v1.0

Comment 2

[Vincent Chang[:vchang][changyihsin]]

Attachment: Patch v1.1

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 699790 [details] [diff] [review]
Patch v1.1

Looks good, thanks.

Comment 4

[Andrew Overholt [:overholt]]

Let's take this but not block on it.

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 699790 [details] [diff] [review]
Patch v1.1

[Triage Comment]

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c5e0b6890104
https://hg.mozilla.org/releases/mozilla-b2g18/rev/39fb27607bbd

My checkin message says a=bb+ when it should say a=jst. Sorry!

Comment 7

[Brion Vibber]

Hmm, looking at that patch... what happens if the password contains a double-quote character?

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c5e0b6890104