Closed Bug 825049 Opened 12 years ago Closed 12 years ago

Wi-Fi hotspot fails if password contains space

Categories

(Firefox OS Graveyard :: Wifi, defect)

Product:
Firefox OS Graveyard
Component:
Wifi
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-basecamp:-, firefox18 wontfix, firefox19 wontfix, b2g18 fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-basecamp -
Tracking Flags:
Tracking Status
firefox18 --- wontfix
firefox19 --- wontfix
b2g18 --- fixed

People

(Reporter: brion, Assigned: vchang)

References

Details

Attachments

(1 file, 1 obsolete file)

Patch v1.1
1.16 KB, patch
mrbkap
: review+
jst
: approval-mozilla-b2g18+
Details | Diff | Splinter Review
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:20.0) Gecko/20121223 Firefox/20.0 Build ID: 20121223030832 Steps to reproduce: Enabling WiFi sharing on my unagi test device works great as long as the password does not contain spaces. No problems with passwords '0123456789' or 'wiresAteMyBrain' or 'wires-AteMyBrain' but 'wires AteMyBrain' or 'wires Ate My Brain' fail. Tested a Mac OS X machine and a Nexus 7 tablet as clients. Actual results: When password has a space, FirefoxHotspot just doesn't show up in networks available on client machines. Expected results: Hotspot should be available just as with passwords not containing spaces. Seems same for WPA and WPA2... and even when setting as 'open'.
Attached patch Patch v1.0 (obsolete) — — Splinter Review
Assignee: nobody → vchang
Attachment #699768 - Flags: review?(mrbkap)
Status: UNCONFIRMED → NEW
blocking-basecamp: --- → ?
Ever confirmed: true
Attached patch Patch v1.1 — — Splinter Review
Attachment #699768 - Attachment is obsolete: true
Attachment #699768 - Flags: review?(mrbkap)
Attachment #699790 - Flags: review?(mrbkap)
Comment on attachment 699790 [details] [diff] [review] Patch v1.1 Looks good, thanks.
Attachment #699790 - Flags: review?(mrbkap) → review+
Let's take this but not block on it.
blocking-basecamp: ? → -
Comment on attachment 699790 [details] [diff] [review] Patch v1.1 [Triage Comment]
Attachment #699790 - Flags: approval-mozilla-b2g18+
Keywords: checkin-needed
Hmm, looking at that patch... what happens if the password contains a double-quote character?
https://hg.mozilla.org/mozilla-central/rev/c5e0b6890104
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: