825129 - Word suggestions are enabled for contact search input

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

STR
 (1) Open SMS app
 (2) Tap "+"
 (3) Focus search box and enter name of existing contact

Word suggestions are offered, but that's not useful at all.

bb? -> radar

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

Triage:BB-, tracking-b2g18+

Comment 2

[ayman maat :maat]

i cannot reproduce this bug
request QA to test if it is still valid.

Comment 3

[:Margaret Leibovic]

(In reply to ayman maat :maat from comment #2)
> i cannot reproduce this bug
> request QA to test if it is still valid.

Are your word suggestions on at all? (How about when you try typing in the compose field of the SMS app?) I believe we recently changed the pref to turn them off by default, so that might be what you're seeing.

This bug is about the fact that even when they're enabled it doesn't make sense for them to show up for the contact search input.

Comment 4

[ayman maat :maat]

(In reply to :Margaret Leibovic (away until Jan 24) from comment #3)
> (In reply to ayman maat :maat from comment #2)
> > i cannot reproduce this bug
> > request QA to test if it is still valid.
> 
> Are your word suggestions on at all? (How about when you try typing in the
> compose field of the SMS app?) I believe we recently changed the pref to
> turn them off by default, so that might be what you're seeing.

I just checked and they are completely turned off. I was not aware of that, thanks for the heads up. 
Removing QAwanted request

Comment 5

[Carlos Martínez Toral [:carlosmartinez]]

Tested in unagi with Gecko-ec7aa64 Gaia-df38c1b, still valid bug.

Comment 6

[Casey Yee]

The bug is still valid.   Word suggestion has been turned off for keyboard responsiveness but doesn't preclude the word suggestions from working properly if turned on.

Comment 7

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Pull Request #9519 - Disable word suggestions for contact search

Make use of 'x-inputmode' attribute, with value 'verbatim', to tell the keyboard to not show word suggestions for the contact search input.

Comment 8

[David Flanagan [:djf]]

Comment on attachment 744839 [details]
Pull Request #9519 - Disable word suggestions for contact search

This is a good patch. r+

Eventually we want to support inputmode=name to make it autocomplete from the list of contacts. So if you want to make this a perfect patch take these two simple extra steps:

1) File a new bug on the contacts app saying that it should use inputmode=name when that is implemented.

2) Add a comment before the line you added saying something like this:

// XXX Bug nnnnnn: change this to inputmode=name when that is supported

There is no need to ask for another review if you do that. I don't know if you have commit rights. Email me if you need me to land this.

Comment 9

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Thanks for the review, David! I filed bug 869661 according to your suggestion (also added you to CC); feel free to add more info to it if there is anything I missed in the brief description.

Merged to master:
https://github.com/mozilla-b2g/gaia/commit/5a48d68de2a8cd793ddea43ee7cfcbfa1c0d3bb9

Comment 10

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Comment on attachment 744839 [details]
Pull Request #9519 - Disable word suggestions for contact search

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): SMS > contact search
User impact if declined: Low (suggestions are shown for contact search which is not useful at all)
Testing completed: Yes
Risk to taking this patch (and alternatives if risky): Low
String or UUID changes made by this patch: No

Comment 11

[Alex Keybl [:akeybl]]

Comment on attachment 744839 [details]
Pull Request #9519 - Disable word suggestions for contact search

Given the fact that this is low risk and a new feature issue, approving for v1.1.

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 5a48d68de2a8cd793ddea43ee7cfcbfa1c0d3bb9
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 13

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

This uplift is no longer required since the patch for bug 837994 (leo+) refactors the solution in apps/sms/js/recipients.js (https://github.com/mozilla-b2g/gaia/blob/v1-train/apps/sms/js/recipients.js#L350).