825132 - verify.py should cleanup stray procs on a foopy prior to pinging device.

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Justin Wood (:Callek)]

Attachment: [tools] cleanup split

So we have had situations where a device goes down for some reason, and we still have stray procs on a foopy.

This usually results in us never cleaning up said stray procs until we can properly recover the device, because verify.py pings a device before it ever runs cleanup.

The downside of course is that we want cleanup that is on the device side itself to always run after we do the other checks, so this patch splits out the foopy specific cleanup to happen earlier, and leaves main() intact to do what it always did (both)

Comment 1

[Justin Wood (:Callek)]

Attachment: [tools] cleanup split (v.1.1)

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 696217 [details] [diff] [review]
[tools] cleanup split (v.1.1)

Review of attachment 696217 [details] [diff] [review]:
-----------------------------------------------------------------

just one style nit below.

::: sut_tools/cleanup.py
@@ +20,5 @@
> +        if errcode == 2:
> +            log.error("processes from previous run were detected and cleaned up")
> +        elif errocode == 3:
> +            setFlag(errorFile, "Remote Device Error: process from previous test run present")
> +            return RETCODE_KILLSTALLED

you could clean this up and just do:
if errcode == 2:
    ...
elif errcode == 3:
    ....

return RETCODE_SUCCESS

The extra 'if errcode > 1' is not needed.

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 696217 [details] [diff] [review]
[tools] cleanup split (v.1.1)

http://hg.mozilla.org/build/tools/rev/64ab223ae560

Comment 4

[Justin Wood (:Callek)]

deployed

Comment 5

[Justin Wood (:Callek)]

http://hg.mozilla.org/build/tools/rev/25df72d408c5
-- Bustage Fix

and
http://hg.mozilla.org/build/tools/rev/21a9999c1371
-- Fix for pre-existing bustage