825146 - Panning contact image in detail view is slow and often doesn't update

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

STR
 (1) Add a contact with an image.  I used Eiffel Tower from stock image set.
 (2) Add lots of contact details, like 10 phone numbers.
 (2) Go to contact detail
 (3) Tap image and pan up and down

Issues
 A. when panning works, the framerate is very low
 B. often I move my finger for 50 pixels or more without the image moving.  Possibly related to (B)
 C. starting the effect in the image, but then moving into the details area, ends up scrolling the entire frame

We could implement this as two transformed frames: contact details in scrollable frame on top of non-scrollable frame containing <img>.  This would get maximum performance.  However, I believe Alberto (?) explained to me at the last work week that the UX spec was to have the image scroll with the text.  In the approach above, that wouldn't work.

So we could either edit the UX spec or make this a "modal" effect.

bb? -> radar

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

Triage:BB-, tracking-b2g18+. maybe 2~3 phone number is more common. 10 numbers is uncommon.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

(In reply to Joe Cheng [:jcheng] from comment #1)
> Triage:BB-, tracking-b2g18+. maybe 2~3 phone number is more common. 10
> numbers is uncommon.

Note, 10 numbers wasn't the key.  The key was several "contact details", which might be a few numbers, a few emails, an address or two, ...

Comment 3

[alberto.pastor]

Chris, you are right, Image must scroll down (slower) with the text. In San Francisco I achieved to don't repaint when using that effect, but it seems that some change regressed it.

Note as well that it works always, the problem is that another regression makes it only work when pulling the image, not the details div.

I would block on this, at least on the "effect not working when pulling the details div" side.

Comment 4

[David Scravaglieri [:scravag]]

We would take a patch for this

Comment 5

[alberto.pastor]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7461

Pointer to Github pull-request

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 700100 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7461

js looking good to me

Comment 7

[alberto.pastor]

Comment on attachment 700100 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7461

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 700100 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7461

This is a regression from the blocking basecamp bug that change the way touch events works that has landed during the week end. Let's fix the last regressions, thanks a lot for it.

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/0238f25bafd160b146cfdef25b086c5dc306c7ed

Comment 10

[mbarone]

Retested with Unagi build

Gecko-feef5f9
Gaia-3c84fa2