825166 - [CONTACTS][es] Contact details are not shown correctly

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P3)

Description

[Carlos Martínez Toral [:carlosmartinez]]

Attachment: Weird transition between contacts list and contact edit mode

Tested in unagi with:

Gecko - b8d7310
Gaia - 73270c3

STR:
1-Add a new contact filling all the fields
2-Try to edit it

Expected result --> You enter in contact edit mode and you´re able to edit every field 

Actual result --> You get the screen you can find in the attachments

Comment 1

[Carlos Martínez Toral [:carlosmartinez]]

Expected result is incorrect, you should get to contact details, but you cannot see them.

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

Triage: BB+, C4, P3 - maybe due to localization in Spanish?

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

QA can you check if this happens only for spanish? Or if it is on all locales?

Comment 4

[Marcia Knous [:marcia]]

Still waiting for the 12-28 build to come out, but using the 2012-12-27-23-02-02 later build I do not see this in English. Trying Spanish next.

Comment 5

[Carlos Martínez Toral [:carlosmartinez]]

I´ve retested this with English (US) and is working fine.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/3eadb55a7c182803a4e36a1853a1b8305adbb987

I have backout the fix that has created the issue and I have reopened it.

Comment 7

[Dylan Oliver [:doliver]]

As far as I can tell, all languages are working in the 12/28 nightly. I'm unable to reproduce what Carlos posted in the screen shot.

Comment 8

[Patryk Adamczyk [:patryk] UX]

Its technically fixed, cause we had to back out a change. But the bug really is... that the content area breaks when the header label is longer. We need to make a change to the header "edit" action. So this needs to be fixed.

Comment 9

[Dylan Oliver [:doliver]]

Attachment: contact detail

(In reply to Patryk Adamczyk [:patryk] UX from comment #8)
> But the bug really
> is... that the content area breaks when the header label is longer. 

That's the part I'm not seeing in today's build. Maybe there are different steps that I'm missing.

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Dylan Oliver [:doliver] from comment #9)
> Created attachment 696382 [details]
> contact detail
> 
> (In reply to Patryk Adamczyk [:patryk] UX from comment #8)
> > But the bug really
> > is... that the content area breaks when the header label is longer. 
> 
> That's the part I'm not seeing in today's build. Maybe there are different
> steps that I'm missing.

Since I have reverted the fix that has created this you can not see it anymore.

Comment 11

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Removing QA wanted since Carlos tested and commented.

Comment 12

[Chris Lee [:clee]]

From a product perspective, bug 820145 is a blocker, this bug will need to be fixed. 

This is already marked blocking so we should keep it.  Plus, Dylan has repeatedly said he cannot reproduce this so we need to figure out the repro steps here.

Comment 14

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Chris Lee [:clee] from comment #12)
> From a product perspective, bug 820145 is a blocker, this bug will need to
> be fixed. 
> 
> This is already marked blocking so we should keep it.  Plus, Dylan has
> repeatedly said he cannot reproduce this so we need to figure out the repro
> steps here.

Chris if Dylan says he can not reproduce this is because I have revert the patch that is the root cause of this bug. Let's not create any confusion anymore and let's close this bug and make sure to fix it / not create it again in the fix that will be done by bug 820145.

Comment 15

[David Scravaglieri [:scravag]]

Chris what do you think about Vivien answer. Do you want to take the risk of changing code in many files ?

Vivien could you estimate LOE and Risk please.