825195 - Update method signatures of TextDecoder and TextEncoder per the latest spec

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: patch

Comment 2

[Masatoshi Kimura [:emk]]

https://tbpl.mozilla.org/?tree=Try&rev=6de426832156

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 696300 [details] [diff] [review]
patch

Review of attachment 696300 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/encoding/TextDecoder.h
@@ +58,5 @@
>  
> +  void Decode(nsAString& aOutDecodedString,
> +              ErrorResult& aRv) {
> +    TextDecoderBase::Decode(EmptyCString().BeginReading(),
> +                            EmptyCString().Length(), false,

You should be able to just pass nullptr and 0 here. The callee should never dereference any of the data anyway since any dereferences would be past the end of the data.

::: dom/workers/TextDecoder.h
@@ +40,5 @@
>    void
> +  Decode(nsAString& aOutDecodedString,
> +         ErrorResult& aRv) {
> +    TextDecoderBase::Decode(EmptyCString().BeginReading(),
> +                            EmptyCString().Length(), false,

Same here

Comment 4

[Masatoshi Kimura [:emk]]

(In reply to Jonas Sicking (:sicking) from comment #3)
> You should be able to just pass nullptr and 0 here. The callee should never
> dereference any of the data anyway since any dereferences would be past the
> end of the data.

Sure. Landed with the fix.
https://hg.mozilla.org/integration/mozilla-inbound/rev/abfe3957551b

Comment 5

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/abfe3957551b