See https://bugzilla.mozilla.org/show_bug.cgi?id=824695#c25. Right now, none of the packaged apps can be installed from marketplace because marketplace is only serving etags for the mini-manifest, not the zip files. This results in the download starting, but failing to finish for any packaged app that was installed from marketplace. This is a smoketest blocker, so this deserves a very high priority.
Any ideas Rob?
I didn't realize the zip files needed an etag also but I'll make this my top priority today. I'm going to assume the same is true for the zip files for reviewers.
https://github.com/mozilla/zamboni/commit/b2bdf7a This adds an ETag header to both the public and reviewer zip files. Just in case it makes any difference, these also use the "X-Accel-Redirect" header for SENDFILE support.
For those of us who don't know about how often marketplace dev gets pushes for patches - when when I be able to try this out? Tomorrow?
(In reply to Jason Smith [:jsmith] from comment #4) > For those of us who don't know about how often marketplace dev gets pushes > for patches - when when I be able to try this out? Tomorrow? Changes on dev show up instantaneously. So 5 minutes after the commit has landed you should see the changes.
Okay, there's definitely no etags showing up: jds2501@nitron:~$ curl -I https://marketplace-dev.allizom.org/downloads/file/181685/test-webapi-permissions-1.3.zip HTTP/1.1 200 OK Server: nginx X-Backend-Server: dev1.addons.phx1.mozilla.com Content-Type: application/zip Date: Fri, 28 Dec 2012 20:55:36 GMT Accept-Ranges: bytes Via: Moz-pp-zlb09 Connection: keep-alive Set-Cookie: lang="en-US\054"; Path=/ Set-Cookie: region=us; Path=/ Last-Modified: Wed, 26 Dec 2012 04:19:38 GMT Content-Length: 19925 Rob - Any ideas?
I checked the -dev server settings and we're using XSENDFILE headers and nginx's X-Accel-Redir. I'm wondering if nginx does an internal redirect and eats the headers I set? Locally, not using nginx, the ETag header shows up for me.
Yep, looks like nginx needs a special directive to tell it to keep the ETag header: http://forum.nginx.org/read.php?2,205636,205665#msg-205665
Jason updated the nginx config so it doesn't eat the etag.
There we go: $ curl -I https://marketplace-dev.allizom.org/downloads/file/181821/test-webapi-permissions-1-1.3.zip HTTP/1.1 200 OK Server: nginx Content-Type: application/zip Date: Fri, 28 Dec 2012 23:15:59 GMT Accept-Ranges: bytes Etag: "fa80ed14a75b7756e4dc952468004657d7bbc53676bc777f6ee5f5b7b8573bdc" Via: Moz-pp-zlb09 Connection: keep-alive Set-Cookie: lang="en-US\054"; Path=/ Set-Cookie: region=us; Path=/ Last-Modified: Fri, 28 Dec 2012 22:32:07 GMT Content-Length: 19927 Let's see what happens if I test this on the phone now...
Tried installing 4 packaged apps on marketplace - we're green as can be. Marking as verified.