Closed Bug 825239 Opened 12 years ago Closed 11 years ago

Yahoo Toolbar doesn't set the default search engine and the homepage after install

Categories

(Firefox :: Extension Compatibility, defect)

Product:
Firefox
Component:
Extension Compatibility
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
firefox19 --- unaffected
firefox20 + affected

People

(Reporter: pauly, Assigned: jnagel)

References

Details

(Keywords: regression)

STR: 1. Open http://us.toolbar.yahoo.com/ 2. Check "Set Yahoo! as default home page and default search" 3. Install the addon 4. Restart Firefox 5. Perform a search by entering something in the location bar and then pressing Enter Expected results: Yahoo search Actual results: Google search Yahoo Toolbar doesn't set the default search engine and the homepage after install I'll come back with a regression range. It seems to be FF 20 related only, works fine in FF 18, 19.
disabled E4X maybe? set "javascript.options.xml.chrome" as "false"
It's false by default
Still doesn't work.
Paul, any luck tracking down a regression range?
Keywords: regressionwindow-wanted
Regression window(m-c) Good: http://hg.mozilla.org/mozilla-central/rev/6fa6e55a93b2 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20121203 Firefox/20.0 ID:20121203160443 Bad: http://hg.mozilla.org/mozilla-central/rev/0035f77045bc Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20121204 Firefox/20.0 ID:20121204065427 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6fa6e55a93b2&tochange=0035f77045bc Regression window(m-i) Good: http://hg.mozilla.org/integration/mozilla-inbound/rev/721a4d74f09e Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20121203 Firefox/20.0 ID:20121203163341 Bad: http://hg.mozilla.org/integration/mozilla-inbound/rev/f2e450529466 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20121203 Firefox/20.0 ID:20121203172641 Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=721a4d74f09e&tochange=f2e450529466 Suspected : Bug 816410
CCing Masatoshi Kimura as the developer for bug 816410. Masatoshi, is there anything in your patch which you suspect may have caused this breakage?
Keywords: regressionwindow-wanted → regression
The extension uses old interface nsIDOMParserJS in components/nsYahooDomBuilder.js >domParser=CC["@mozilla.org/xmlextras/domparser;1"].createInstance(CI.nsIDOMParserJS);domParser.init(sysPrincipal,null,null);
Was this interface deprecated in Firefox 20?
Yes. Do we have Yahoo toolbar contacts?
tracking-firefox20: --- → ?
If we really wanted to, we could leave nsIDOMParserJS as an empty interface...
I think our path forward (comment 10 or 11) should be decided based upon the prevalence of the interface (needinfo?:jorgev to check https://mxr.mozilla.org/addons/), and whether comment 11 would fully resolve the issue.
Flags: needinfo?(jorge)
I did an AMO MXR search, there were no other users of the interface. Direct contact with Yahoo is probably the best way forward, if possible.
Is nsIDOMParserJS the only interface that was dropped? I can confirm Gavin's findings regarding nsIDOMParserJS, but I do see several uses of the same component QI'd to nsIDOMParser instead.
Flags: needinfo?(jorge)
Cc["@mozilla.org/xmlextras/domparser;1"].createInstance(Ci.nsIDOMParser); still works fine.
Joanne or Kev will likely know somebody at Yahoo that I can reach out to. Including them.
status-firefox19: --- → unaffected
status-firefox20: --- → affected
tracking-firefox20: ? → +
Flags: needinfo?(jnagel)
Sorry, is there still an outstanding request on this? If so, can you provide more context as I'll need to route through a business person... Thanks, Joanne
Flags: needinfo?(jnagel)
Blocks: 816410
Joanne - the context is in comment 13 - Yahoo's toolbar is the only add-on continuing to use a dropped interface (nsIDOMParserJS) which is causing the issue in Comment 0 stating that "Yahoo Toolbar doesn't set the default search engine and the homepage after install". Outreach should be done to Yahoo's toolbar developers letting them know their add-on is no longer working as they intended and an updated add-on pushed to their users.
Flags: needinfo?(jnagel)
Thanks, Lukas, that's exactly what I was looking for. I will share this with my business counterparts and have them inform their Toolbar developers. Thanks, Joanne
Flags: needinfo?(jnagel)
Thanks for following up on this Joanne!
Assignee: nobody → jnagel
Update - shared details with Yahoo Business team last week, followed up again yesterday, still no details. JN
Finally, a response from Yahoo: our teams are aware of this issue and they are currently working on a fix. The ETA of the fix is March 25th. I have asked for an update if this date slips for any reason. Joanne
(In reply to Joanne Nagel from comment #22) > Finally, a response from Yahoo: > our teams are aware of this issue and they are currently working on a fix. > The ETA of the fix is March 25th. > > I have asked for an update if this date slips for any reason. Joanne Hi Joanne - just checking in if you can see if this is taken care of now we're a week away from shipping FF20 and about to build our final beta & release candidate.
Flags: needinfo?(jnagel)
Hi, this was resolved wasn't it? Can we close this bug?
Flags: needinfo?(jnagel)
Still an issue on nightly 24.0a1 (2013-06-03) using the STR in comment 0. If I restart FF one more time after the STR, the search engine is finally changed properly.
That particular problem might be fixed by bug 860560.
WFM in 31.0a1 (2014-04-09), Win 7 x64
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.