82524 - Memory leak in nsMsgNewsFolder::SetCachedNewsrcLine

Status: VERIFIED DUPLICATE of bug 66867

(MailNews Core :: Networking: NNTP, defect)

Description

[Daniel Bratell]

nsMsgNewsFolder::SetCachedNewsrcLine(const char *newsrcLine) doesn't check if 
mCachedNewsrcLine already has a value which it might have. It has when called 
with the stack:
nsMsgNewsFolder::SetCachedNewsrcLine(...) line 1554
nsMsgNewsFolder::UpdateSummaryFromNNTPInfo(...) line 872 + 25 bytes
nsNntpIncomingServer::DisplaySubscribedGroup(...) line 663 + 24 bytes

Patch:

    if (!newsrcLine) return NS_ERROR_NULL_POINTER;
+   PR_FREEIF(mCachedNewsrcLine);
    mCachedNewsrcLine = nsCRT::strdup(newsrcLine);
    
    if (!mCachedNewsrcLine) return NS_ERROR_OUT_OF_MEMORY;

    return NS_OK;

Comment 1

[Håkan Waara]

I believe this is a duplicate of bug 66867 which already has a fix attached.

Comment 2

[Håkan Waara]

I'm sure it is. Duplicating.

*** This bug has been marked as a duplicate of 66867 ***

Comment 3

[[e-mail] (gone - use [e-mail] instead)]

Yes, a dup.