Last Comment Bug 825279 - Remove outcommented code in msgHdrViewOverlay.js::ShowMessageHeaderPane()
: Remove outcommented code in msgHdrViewOverlay.js::ShowMessageHeaderPane()
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Message Reader UI (show other bugs)
: Trunk
: All All
: -- enhancement (vote)
: Thunderbird 21.0
Assigned To: Sebastian H. [:aryx][:archaeopteryx]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-28 10:57 PST by Sebastian H. [:aryx][:archaeopteryx]
Modified: 2013-01-16 14:28 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch v1 (1.43 KB, patch)
2012-12-28 10:57 PST, Sebastian H. [:aryx][:archaeopteryx]
mconley: review+
Details | Diff | Review
patch v2, r=mconley, with DONTBUILD in commit message (1.52 KB, patch)
2013-01-15 10:53 PST, Sebastian H. [:aryx][:archaeopteryx]
no flags Details | Diff | Review

Description Sebastian H. [:aryx][:archaeopteryx] 2012-12-28 10:57:57 PST
Created attachment 696347 [details] [diff] [review]
patch v1

There was a hack in msgHdrViewOverlay.js::ShowMessageHeaderPane() which got disabled (transformed into a comment) 3 1/2 years ago and the bug was reported for the last time 10 years ago (see bug 39655), so this code/comment should go away.
Comment 1 Mike Conley (:mconley) - (needinfo me!) 2013-01-14 16:11:24 PST
Comment on attachment 696347 [details] [diff] [review]
patch v1

Review of attachment 696347 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Comment 2 Sebastian H. [:aryx][:archaeopteryx] 2013-01-15 10:53:31 PST
Created attachment 702422 [details] [diff] [review]
patch v2, r=mconley, with DONTBUILD in commit message
Comment 3 Ryan VanderMeulen [:RyanVM] 2013-01-16 14:28:00 PST
https://hg.mozilla.org/comm-central/rev/bf3e9bfb110b

Note You need to log in before you can comment on or make changes to this bug.