825285 - Move ArchiveReader to Paris bindings

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part a: Don't pass around ArchiveReaderOptions

I don't really see the point in passing around a struct with one member, and I'd prefer not having to change the type all over (because this is an XPIDL dictionary, not a WebIDL one).

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part b: Move ArchiveReader to Paris bindings, remove XPCOM goop

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 696482 [details] [diff] [review]
Part b: Move ArchiveReader to Paris bindings, remove XPCOM goop

Sorry, I'm swamped. I'll defer to khuey.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part a: Don't pass around ArchiveReaderOptions (v2)

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part b: Move ArchiveReader to Paris bindings, remove XPCOM goop (v2)

Comment 6

[Masatoshi Kimura [:emk]]

By the way, do we need this interface at all? It is pref'ed off, neither W3C nor WHATWG has a spec about this, and nobody is going to proceed.

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 714495 [details] [diff] [review]
Part b: Move ArchiveReader to Paris bindings, remove XPCOM goop (v2)

Review of attachment 714495 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/file/ArchiveReader.cpp
@@ +27,1 @@
>  {

MOZ_ASSERT aBlob?  and maybe PrefEnabled() too?

@@ +49,1 @@
>    MOZ_COUNT_CTOR(ArchiveReader);

Remove MOZ_COUNT_CTOR while you're here.  This object is refcounted so this is pointless.

@@ +52,5 @@
>  }
>  
>  ArchiveReader::~ArchiveReader()
>  {
>    MOZ_COUNT_DTOR(ArchiveReader);

Ditto.

::: dom/file/ArchiveReader.h
@@ +32,5 @@
>  /**
>   * This is the ArchiveReader object
>   */
> +class ArchiveReader MOZ_FINAL : public nsISupports
> +                              , public nsWrapperCache

super-nit: , after nsISupports please.

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/10fa33c73a0b
https://hg.mozilla.org/mozilla-central/rev/c79295994ef8