825291 - remove nsISupportsArray from nsPKIParamBlock

Status: RESOLVED INVALID

(Core :: Security: PSM, defect)

Description

[Trevor Saunders (:tbsaunde)]

I can see two options here
1. replace nsCOMPtr<nsISupportsArray> with nsCOMArray<nsISupports>
2. nuke nsIPKIParamBlock.Set/get ISupportAtIndex() which seem to be unused, and a rather odd api to provide here...

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: remove nsISupportsArray from nsPKIParamBlock

this implements option 1 that I mentioned, but I'd happily do option 2 if there's no reason to keep this stuff.

Comment 2

[:aceman]

Ping bsmith...

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 696368 [details] [diff] [review]
remove nsISupportsArray from nsPKIParamBlock

Is this bug still valid? If so, perhaps :keeler would be a better reviewer for this, since it seems like UI code I'm not familiar with.

Comment 4

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 696368 [details] [diff] [review]
remove nsISupportsArray from nsPKIParamBlock

Review of attachment 696368 [details] [diff] [review]:
-----------------------------------------------------------------

Well, for better or worse it is used, but in a very limited way. Let's change it so nsIPKIParamBlock just has an 'attribute nsIX509Cert cert', since that's all it's used for: https://mxr.mozilla.org/mozilla-central/ident?i=SetISupportAtIndex https://mxr.mozilla.org/mozilla-central/ident?i=GetISupportAtIndex

Comment 5

[:Cykesiopka]

Bug 1217602 removed nsPKIParamBlock entirely, so there's nothing to do here anymore.