825327 - Warning in FTU app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

While running the FTU app, after hitting "next" for the last step (the one that leads into the tutorial) I get:

E/GeckoConsole( 7733): [JavaScript Error: "TypeError: steps[this.currentStep] is undefined" {file: "app://communications.gaiamobile.org/ftu/js/navigation.js" line: 222}]

in adb. This is an easy bug to fix.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Easy patch, v1

This patch does beg the question: why do we use an object with numbered steps (beginning at 1 rather than 0) rather than an array?

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 696408 [details] [diff] [review]
Easy patch, v1

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Changing the reviewer to fcampo, as he is the one working on FTU and I'm on PTO till the 7th of January.

Thx.

Comment 3

[Fernando Campo (:fcampo)]

Comment on attachment 696408 [details] [diff] [review]
Easy patch, v1

easy patch, low risk. Thanks for fixing it mrkbap

and about your question, FTU was created when the design was still changing, so the object had sense at the moment. Later on, as always happens with this, refactor was less critical than bug fixing. The app certainly needs full revisiting and refactor to improve performance, but deadlines and workload are taking us away from it at the moment :)

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 696408 [details] [diff] [review]
Easy patch, v1

Non risky change

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Hi Blake, couldn't find the PR in github for this bug, can you do it and merge?

Already have approval and r+

Thanks a lot!

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

Merged in https://github.com/mozilla-b2g/gaia/pull/7284

Thanks.