Separate ModifierKeyState from KeyboardLayout

NEW
Unassigned

Status

()

6 years ago
6 years ago

People

(Reporter: TimAbraldes, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 696417 [details] [diff] [review]
patch v1 (WIP)

ModifierKeyState is used in MetroInput.cpp, WinMouseScrollHandler.cpp, and nsNativeDragTarget.cpp, but none of those files use the other classes in KeyboardLayout.h

It should be possible to safely separate ModifierKeyState from KeyboardLayout
Hmm, I don't understand why we need to get rid of KeyboardLayout from MetroWidget. I checked MetroInput::InitializeVirtualKeyMap() now. Then, I was surprised. That doesn't care non-US keyboard layout. DOM keyCode cannot be simply mapped from only virtual keycode value. See bug 630810. I think that MetroWidget should use KeyboardLayout if it's possible.
(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #1)
> Hmm, I don't understand why we need to get rid of KeyboardLayout from
> MetroWidget. I checked MetroInput::InitializeVirtualKeyMap() now. Then, I
> was surprised. That doesn't care non-US keyboard layout. DOM keyCode cannot
> be simply mapped from only virtual keycode value. See bug 630810. I think
> that MetroWidget should use KeyboardLayout if it's possible.

This bug is about separating ModifierKeyState from KeyboardLayout.  I've filed bug 843236 so that we can discuss MetroWidget's use of KeyboardLayout.

Additionally, this bug is more about "organization and neatness" than about real improvements, so I'm un-assigning myself since I should be working on more important metro work :)
Assignee: tabraldes → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.