825397 - Duplicate <div> label may be inserted into Range Components after loading another section.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[qichao]

Attachment: One_Div_Screen_Capture

In Settings, first go to Sound section, the Range Component will be inserted a <div> label.
Then go to Display section, the hidden Range Component in Sound section will be insert another <div> label.

In current UI layout, the problem can hardly be noticed.
But if the space of the <li> label is extended (e.g. the space for each line of Ringer, Alarm, Tones is added by some px). There will be two paralleled of range component displayed.

Screen Captures will be updated as attachment to illustrate the problem.

Comment 1

[qichao]

Attachment: Two_Div_Screen_Capture

Comment 2

[Steven Yang [:styang]]

Rudy, please help to check this issue.

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7698

Pointer to Github pull-request

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 704424 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7698

Hi Kaze,

This is a simple patch that not to redundantly replace all input elements with the polyfill() magic again.

Thanks.

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: screenshot for corrupted display settings

** Triage **
Nominate this as blocking because it is an obvious UI issue with a simple STR.
Please refer to the attachment.

STR
====
1. Go to settings.
2. Go to display settings and then Sound settings.
3. Go back to display => issue reproduced.

Comment 6

[Dietrich Ayala (:dietrich)]

(In reply to qichao from comment #0)
> In current UI layout, the problem can hardly be noticed.

Blocking- because this. We couldn't reproduce in triage. How did you reproduce?

Comment 7

[Fabien Cazenave [:kaze]]

Comment on attachment 704424 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7698

Good catch, thanks.

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

This issue has been fixed by the following commit from Bug 808250,
https://github.com/mozilla-b2g/gaia/commit/d079a79acbe55325f5203f84037bc6a6c961c3e7

Note: this commit has NOT been merged into v1.0.0 branch.
Only in master and v1-train.